Skip to content

Commit d72093d

Browse files
freshp86Devtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
Remove refs to Grit's output_all_resource_defines option.
This option is no longer respected by Grit, as of crrev.com/c/786121 (~7 years ago), but it is still present in a lot of grd files. Bug: 389466679 Change-Id: I4f9b5873fbfdd6e3548f875c27c1de825837a595 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6187824 Reviewed-by: Alex Rudenko <[email protected]> Auto-Submit: Demetrios Papadopoulos <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Reviewed-by: Simon Zünd <[email protected]>
1 parent bbc742a commit d72093d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

inspector_overlay/resources.grd

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<grit latest_public_release="0" current_release="1" output_all_resource_defines="false">
2+
<grit latest_public_release="0" current_release="1">
33
<outputs>
44
<output filename="grit/inspector_overlay_resources_map.h" type="rc_header">
55
<emit emit_type="prepend"></emit>

scripts/build/generate_devtools_grd.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737

3838
kDevToolsResourcePrefix = 'IDR_DEVTOOLS_'
3939
kGrdTemplate = '''<?xml version="1.0" encoding="UTF-8"?>
40-
<grit latest_public_release="0" current_release="1"
41-
output_all_resource_defines="false">
40+
<grit latest_public_release="0" current_release="1">
4241
<outputs>
4342
<output filename="grit/devtools_resources.h" type="rc_header">
4443
<emit emit_type='prepend'></emit>

0 commit comments

Comments
 (0)