Skip to content

Commit 8d14fa9

Browse files
bmeurerDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
[DevToolsIcon] Update remaining uses of the info icon to GM3.
Also delete the already unused info-icon.svg. Screenshot: https://imgur.com/VyzVtu9.png Bug: chromium:1427397 Change-Id: I2a89c6271512f80a74b619acd2dfdafa7a6799ba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4445939 Commit-Queue: Benedikt Meurer <[email protected]> Auto-Submit: Benedikt Meurer <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent 6e19d5c commit 8d14fa9

File tree

6 files changed

+9
-5
lines changed

6 files changed

+9
-5
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ grd_files_release_sources = [
145145
"front_end/Images/iframe-crossed.svg",
146146
"front_end/Images/iframe.svg",
147147
"front_end/Images/import.svg",
148-
"front_end/Images/info-icon.svg",
149148
"front_end/Images/info.svg",
150149
"front_end/Images/issue-cross-filled.svg",
151150
"front_end/Images/issue-exclamation-filled.svg",

config/gni/devtools_image_files.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ devtools_svg_sources = [
150150
"iframe-crossed.svg",
151151
"iframe.svg",
152152
"import.svg",
153-
"info-icon.svg",
154153
"info.svg",
155154
"issue-cross-filled.svg",
156155
"issue-exclamation-filled.svg",

front_end/Images/src/info-icon.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

front_end/panels/application/StorageView.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import * as i18n from '../../core/i18n/i18n.js';
77
import * as Platform from '../../core/platform/platform.js';
88
import * as SDK from '../../core/sdk/sdk.js';
99
import * as Protocol from '../../generated/protocol.js';
10+
import * as IconButton from '../../ui/components/icon_button/icon_button.js';
1011
import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
1112
import * as UI from '../../ui/legacy/legacy.js';
1213

@@ -505,8 +506,10 @@ export class StorageView extends UI.ThrottledWidget.ThrottledWidget {
505506
{PH1: response.usage.toLocaleString(), PH2: response.quota.toLocaleString()}));
506507

507508
if (!response.overrideActive && response.quota < 125829120) { // 120 MB
509+
const icon = new IconButton.Icon.Icon();
510+
icon.data = {iconName: 'info', color: 'var(--icon-info)', width: '14px', height: '14px'};
508511
UI.Tooltip.Tooltip.install(this.quotaRow, i18nString(UIStrings.storageQuotaIsLimitedIn));
509-
this.quotaRow.appendChild(UI.Icon.Icon.create('smallicon-info'));
512+
this.quotaRow.appendChild(icon);
510513
}
511514

512515
if (this.quotaUsage === null || this.quotaUsage !== response.usage) {

front_end/ui/legacy/components/cookie_table/CookiesTable.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import * as SDK from '../../../../core/sdk/sdk.js';
4040
import * as Protocol from '../../../../generated/protocol.js';
4141
import * as IssuesManager from '../../../../models/issues_manager/issues_manager.js';
4242
import * as NetworkForward from '../../../../panels/network/forward/forward.js';
43+
import * as IconButton from '../../../components/icon_button/icon_button.js';
4344
import * as UI from '../../legacy.js';
4445
import * as DataGrid from '../data_grid/data_grid.js';
4546

@@ -777,7 +778,9 @@ export class DataGridNode extends DataGrid.DataGrid.DataGridNode<DataGridNode> {
777778
}
778779

779780
if (blockedReasonString) {
780-
const infoElement = UI.Icon.Icon.create('smallicon-info', 'cookie-warning-icon');
781+
const infoElement = new IconButton.Icon.Icon();
782+
infoElement.data = {iconName: 'info', color: 'var(--icon-info)', width: '14px', height: '14px'};
783+
infoElement.classList.add('cookie-warning-icon');
781784
UI.Tooltip.Tooltip.install(infoElement, blockedReasonString);
782785
cell.insertBefore(infoElement, cell.firstChild);
783786
cell.classList.add('flagged-cookie-attribute-cell');

front_end/ui/legacy/components/cookie_table/cookiesTable.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
.cookies-table .cookie-warning-icon {
1919
margin-right: 4px;
20+
margin-bottom: -2px;
2021
}
2122

2223
.cookies-table td.flagged-cookie-attribute-cell .cookie-warning-icon {

0 commit comments

Comments
 (0)