Skip to content

Commit 2fa2c1c

Browse files
hanselfmu-chromiumDevtools-frontend LUCI CQ
authored andcommitted
Fix nesting style issues
This fixes two issues: 1. the checkbox of the declaration toggle is a little bit lower than the center, therefore we reduce the `top` value by 0.5px. 2. the checkbox still shows up when editing styles due to specificity. Therefore we changed the selector to only show it when the style is not being edited. Fixed: b/328403286 Change-Id: If592ae1c33eb10ae91ed3f3b459cda7919e2b214 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5439573 Auto-Submit: Changhao Han <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]> Commit-Queue: Changhao Han <[email protected]>
1 parent 57f1eca commit 2fa2c1c

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

front_end/panels/elements/stylePropertiesTreeOutline.css

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,10 @@ ol.expanded {
110110
z-index: 1;
111111
width: 18px;
112112
left: -40px; /* original -2px + (-38px) to compensate for the first line outdent */
113-
top: 1px;
113+
top: 0.5px;
114114
height: 13px;
115115
}
116116

117-
.tree-outline li.child-editing .enabled-button {
118-
visibility: hidden;
119-
}
120-
121117
.overloaded:not(.has-ignorable-error, .invalid-property-value),
122118
.inactive:not(.invalid-property-value),
123119
.disabled,
@@ -265,11 +261,8 @@ ol.expanded {
265261
display: none;
266262
}
267263

268-
:host-context(.matched-styles:not(.read-only):hover) .enabled-button {
269-
visibility: visible;
270-
}
271-
272-
:host-context(.matched-styles:not(.read-only)) .tree-outline li.disabled .enabled-button {
264+
:host-context(.matched-styles:not(.read-only):hover) li:not(.child-editing) .enabled-button,
265+
:host-context(.matched-styles:not(.read-only)) .tree-outline li.disabled:not(.child-editing) .enabled-button {
273266
visibility: visible;
274267
}
275268

0 commit comments

Comments
 (0)