[chai] Use assert global provided by karma-chai.

This removes the pattern

```js
const {assert} = chai;
```

from our unit test suite, which is fundamentally incompatible with
TypeScript `asserts`, which we intend to put onto Chai assert
functions. And this is also unnecessary, since `karma-chai` (and
also `karma-chai-sinon`) already provide `assert` as a global (with
the proper types).

Bug: 333520272
Change-Id: Id5dfd65903b5b116414709782c7923fc5523e480
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5439575
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>

Author: bmeurer

front_end/core/common/Base64.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('Base64 decoder', () => {

front_end/core/common/CharacterIdMap.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const CharacterIdMap = Common.CharacterIdMap.CharacterIdMap;

front_end/core/common/Color.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const Color = Common.Color;

front_end/core/common/ColorConverter.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 function assertAlmostEqual(array1: number[], array2: number[], delta = 0.01) {

front_end/core/common/ColorUtils.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('ColorUtils', () => {

front_end/core/common/Console.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const Console = Common.Console.Console;

front_end/core/common/Debouncer.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('Debouncer', () => {

front_end/core/common/Lazy.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const lazy = Common.Lazy.lazy;

front_end/core/common/Mutex.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('Mutex', () => {

front_end/core/common/Object.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('ObjectWrapper', () => {

front_end/core/common/ParsedURL.test.ts

@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
+import type * as Platform from '../platform/platform.js';
 
 import * as Common from './common.js';
-import type * as Platform from '../platform/platform.js';
 
 const ParsedURL = Common.ParsedURL.ParsedURL;
 

front_end/core/common/Progress.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const CompositeProgress = Common.Progress.CompositeProgress;

front_end/core/common/ResolverBase.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 class TestClass {}

front_end/core/common/ResourceType.test.ts

@@ -2,12 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
-import * as Common from './common.js';
+import {describeWithEnvironment} from '../../testing/EnvironmentHelpers.js';
 import type * as Platform from '../platform/platform.js';
 
-import {describeWithEnvironment} from '../../testing/EnvironmentHelpers.js';
+import * as Common from './common.js';
 
 const ResourceType = Common.ResourceType.ResourceType;
 const ResourceCategory = Common.ResourceType.ResourceCategory;

front_end/core/common/Revealer.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 describe('Revealer', () => {

front_end/core/common/SegmentedRange.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const Segment = Common.SegmentedRange.Segment;

front_end/core/common/SettingRegistration.test.ts

@@ -11,8 +11,6 @@ import * as i18n from '../i18n/i18n.js';
 
 import * as Common from './common.js';
 
-const {assert} = chai;
-
 const settingName = 'mock-setting';
 const settingTitle = 'Mock setting';
 const enableTitle = 'Enable mock setting';

front_end/core/common/Settings.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const SettingsStorage = Common.Settings.SettingsStorage;

front_end/core/common/SimpleHistoryManager.test.ts

@@ -4,7 +4,6 @@
 
 import * as Common from './common.js';
 
-const {assert} = chai;
 const SimpleHistoryManager = Common.SimpleHistoryManager.SimpleHistoryManager;
 
 class Entry implements Common.SimpleHistoryManager.HistoryEntry {

front_end/core/common/StringOutputStream.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const StringOutputStream = Common.StringOutputStream.StringOutputStream;

front_end/core/common/TextDictionary.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const TextDictionary = Common.TextDictionary.TextDictionary;

front_end/core/common/Throttler.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const Throttler = Common.Throttler.Throttler;

front_end/core/common/Trie.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const Trie = Common.Trie.Trie;

front_end/core/common/WasmDisassembly.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as Common from './common.js';
 
 const WasmDisassembly = Common.WasmDisassembly.WasmDisassembly;

front_end/core/dom_extension/DOMExtension.test.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
 import './dom_extension.js';
 
 declare global {

front_end/core/host/AidaClient.test.ts

@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Host from './host.js';
 import * as Root from '../root/root.js';
 
-const {assert} = chai;
+import * as Host from './host.js';
 
 const TEST_MODEL_ID = 'testModelId';
 

front_end/core/i18n/DevToolsLocale.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as i18n from './i18n.js';
 
 describe('DevToolsLocale', () => {

front_end/core/i18n/i18n.test.ts

@@ -2,12 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
-import * as i18n from './i18n.js';
+import {assertElement} from '../../testing/DOMHelpers.js';
 import * as i18nRaw from '../../third_party/i18n/i18n.js';
 
-import {assertElement} from '../../testing/DOMHelpers.js';
+import * as i18n from './i18n.js';
 
 describe('serializeUIString', () => {
   it('serializes strings without placeholders', () => {

front_end/core/i18n/time-utilities.test.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
-
 import * as i18n from './i18n.js';
 
 describe('preciseMillisToString', () => {

front_end/core/platform/ArrayUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 function comparator(a: number, b: number): number {
   return a < b ? -1 : (a > b ? 1 : 0);
 }

front_end/core/platform/DOMUtilities.test.ts

@@ -6,8 +6,6 @@ import {renderElementIntoDOM} from '../../testing/DOMHelpers.js';
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('DOMUtilities', () => {
   describe('deepActiveElement', () => {
     it('returns the active element if there is no shadow root', () => {

front_end/core/platform/DateUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('DateUtilities', () => {
   describe('isValid', () => {
     it('returns true for a valid date', () => {

front_end/core/platform/KeyboardUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('KeyboardUtilities', () => {
   describe('#keyIsArrowKey', () => {
     it('returns true for ArrowUp, ArrowDown, ArrowLeft and ArrowRight', () => {

front_end/core/platform/MapUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('MapUtilities', () => {
   describe('inverse', () => {
     it('inverts the map returning a multimap with the map\'s values as keys and the map\'s keys as values', () => {

front_end/core/platform/NumberUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('NumberUtilities', () => {
   describe('clamp', () => {
     it('takes the lower bound if the number is smaller', () => {

front_end/core/platform/SetUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Plaform from './platform.js';
 
-const {assert} = chai;
-
 describe('SetUtilities', () => {
   describe('addAll', () => {
     it('adds all items in the iterable to the set', () => {

front_end/core/platform/StringUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('StringUtilities', () => {
   describe('escapeCharacters', () => {
     it('escapes the given characters', () => {

front_end/core/platform/TypedArrayUtilities.test.ts

@@ -4,8 +4,6 @@
 
 import * as Platform from './platform.js';
 
-const {assert} = chai;
-
 describe('TypedArrayUtilities', () => {
   describe('BigUint32Array', () => {
     it('can be expandable', () => {

front_end/core/protocol_client/NodeURL.test.ts

@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {assert} = chai;
+import * as Host from '../host/host.js';
 
 import * as ProtocolClient from './protocol_client.js';
-import * as Host from '../host/host.js';
 
 describe('NodeURL', () => {
   describe('platform detection for paths', () => {

front_end/core/root/Runtime.test.ts

@@ -4,8 +4,6 @@
 
 import * as Root from './root.js';
 
-const {assert} = chai;
-
 describe('Runtime', () => {
   beforeEach(() => {
     Root.Runtime.experiments.clearForTest();

front_end/core/sdk/AccessibilityModel.test.ts

@@ -7,8 +7,6 @@ import {describeWithMockConnection} from '../../testing/MockConnection.js';
 
 import * as SDK from './sdk.js';
 
-const {assert} = chai;
-
 describeWithMockConnection('AccessibilityModel', () => {
   it('can be instantiated', () => {
     assert.doesNotThrow(() => {

front_end/core/sdk/AutofillModel.test.ts

@@ -8,8 +8,6 @@ import {describeWithMockConnection} from '../../testing/MockConnection.js';
 
 import * as SDK from './sdk.js';
 
-const {assert} = chai;
-
 describeWithMockConnection('AutofillModel', () => {
   it('can enable and disable the Autofill CDP domain', () => {
     const target = createTarget();