[Fusion] Refactored rule "ExternalArgumentDefaultMismatchRule" (#8196)

Author: glen-84

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Logging/LogEntryHelper.cs

@@ -203,17 +203,29 @@ public static LogEntry EnumValuesMismatch(
     }
 
     public static LogEntry ExternalArgumentDefaultMismatch(
-        string argumentName,
+        IValueNode? externalDefaultValue,
+        MutableInputFieldDefinition externalArgument,
         string fieldName,
-        string typeName)
+        string typeName,
+        MutableSchemaDefinition externalSchema,
+        IValueNode? defaultValue,
+        string schemaName)
     {
-        var coordinate = new SchemaCoordinate(typeName, fieldName, argumentName);
+        var coordinate = new SchemaCoordinate(typeName, fieldName, externalArgument.Name);
 
         return new LogEntry(
-            string.Format(LogEntryHelper_ExternalArgumentDefaultMismatch, coordinate),
+            string.Format(
+                LogEntryHelper_ExternalArgumentDefaultMismatch,
+                externalDefaultValue is null ? "(null)" : externalDefaultValue.ToString(),
+                coordinate,
+                externalSchema.Name,
+                defaultValue is null ? "(null)" : defaultValue.ToString(),
+                schemaName),
             LogEntryCodes.ExternalArgumentDefaultMismatch,
             LogSeverity.Error,
-            coordinate);
+            coordinate,
+            externalArgument,
+            externalSchema);
     }
 
     public static LogEntry ExternalMissingOnBase(

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/PreMergeValidationRules/ExternalArgumentDefaultMismatchRule.cs

@@ -2,8 +2,9 @@
 using HotChocolate.Fusion.Events;
 using HotChocolate.Fusion.Events.Contracts;
 using HotChocolate.Fusion.Extensions;
-using HotChocolate.Language;
+using HotChocolate.Fusion.Info;
 using static HotChocolate.Fusion.Logging.LogEntryHelper;
+using static HotChocolate.Language.SyntaxComparer;
 
 namespace HotChocolate.Fusion.PreMergeValidationRules;
 
@@ -21,7 +22,10 @@ public void Handle(OutputFieldGroupEvent @event, CompositionContext context)
     {
         var (fieldName, fieldGroup, typeName) = @event;
 
-        if (!fieldGroup.Any(i => i.Field.HasExternalDirective()))
+        var externalFieldGroup =
+            fieldGroup.Where(i => i.Field.HasExternalDirective()).ToImmutableHashSet();
+
+        if (externalFieldGroup.IsEmpty)
         {
             return;
         }
@@ -32,18 +36,35 @@ public void Handle(OutputFieldGroupEvent @event, CompositionContext context)
 
         foreach (var argumentName in argumentNames)
         {
-            var arguments = fieldGroup
-                .SelectMany(i => i.Field.Arguments.AsEnumerable().Where(a => a.Name == argumentName))
-                .ToImmutableArray();
+            var argumentGroup =
+                fieldGroup
+                    .SelectMany(
+                        i => i.Field.Arguments.AsEnumerable().Where(a => a.Name == argumentName),
+                        (i, a) => new FieldArgumentInfo(a, i.Field, i.Type, i.Schema))
+                    .ToImmutableHashSet();
 
-            var defaultValue = arguments[0].DefaultValue;
+            var externalArgumentGroup =
+                externalFieldGroup
+                    .SelectMany(
+                        i => i.Field.Arguments.AsEnumerable().Where(a => a.Name == argumentName),
+                        (i, a) => new FieldArgumentInfo(a, i.Field, i.Type, i.Schema));
 
-            foreach (var argument in arguments)
+            foreach (var (externalArgument, _, _, externalSchema) in externalArgumentGroup)
             {
-                if (!SyntaxComparer.BySyntax.Equals(argument.DefaultValue, defaultValue))
+                foreach (var (argument, _, _, schema) in argumentGroup)
                 {
-                    context.Log.Write(
-                        ExternalArgumentDefaultMismatch(argumentName, fieldName, typeName));
+                    if (!BySyntax.Equals(argument.DefaultValue, externalArgument.DefaultValue))
+                    {
+                        context.Log.Write(
+                            ExternalArgumentDefaultMismatch(
+                                externalArgument.DefaultValue,
+                                externalArgument,
+                                fieldName,
+                                typeName,
+                                externalSchema,
+                                argument.DefaultValue,
+                                schema.Name));
+                    }
                 }
             }
         }

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.Designer.cs

@@ -172,7 +172,7 @@
     <value>The enum type '{0}' in schema '{1}' must define the value '{2}'.</value>
   </data>
   <data name="LogEntryHelper_ExternalArgumentDefaultMismatch" xml:space="preserve">
-    <value>The argument with schema coordinate '{0}' has inconsistent default values.</value>
+    <value>The default value '{0}' of external argument '{1}' in schema '{2}' differs from the default value of '{3}' in schema '{4}'.</value>
   </data>
   <data name="LogEntryHelper_ExternalMissingOnBase" xml:space="preserve">
     <value>The external field '{0}' in schema '{1}' is not defined (non-external) in any other schema.</value>

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.resx

@@ -109,8 +109,8 @@ type Product {
                     """
                 ],
                 [
-                    "The argument with schema coordinate 'Product.name(language:)' has " +
-                    "inconsistent default values."
+                    "The default value '\"de\"' of external argument 'Product.name(language:)' " +
+                    "in schema 'B' differs from the default value of '\"en\"' in schema 'A'."
                 ]
             },
             // In the following example, the "name" field on "Product" is defined in one source
@@ -132,12 +132,12 @@ type Product {
                     """
                 ],
                 [
-                    "The argument with schema coordinate 'Product.name(language:)' has " +
-                    "inconsistent default values."
+                    "The default value '(null)' of external argument 'Product.name(language:)' " +
+                    "in schema 'B' differs from the default value of '\"en\"' in schema 'A'."
                 ]
             },
-            // Here, the "name" field on "Product" is defined without a default value in the
-            // non-external source schema, violating the rule.
+            // Here, the "name" field on "Product" is defined without a default value for the
+            // "language" argument in the non-external source schema, violating the rule.
             {
                 [
                     """
@@ -152,8 +152,8 @@ type Product {
                     """
                 ],
                 [
-                    "The argument with schema coordinate 'Product.name(language:)' has " +
-                    "inconsistent default values."
+                    "The default value '\"en\"' of external argument 'Product.name(language:)' " +
+                    "in schema 'B' differs from the default value of '(null)' in schema 'A'."
                 ]
             },
             // Here, the "name" field on "Product" is defined with multiple arguments. One argument
@@ -172,8 +172,9 @@ type Product {
                     """
                 ],
                 [
-                    "The argument with schema coordinate 'Product.name(localization:)' has " +
-                    "inconsistent default values."
+                    "The default value '\"sa\"' of external argument " +
+                    "'Product.name(localization:)' in schema 'B' differs from the default value " +
+                    "of '\"sr\"' in schema 'A'."
                 ]
             },
             // Here, the "name" field on "Product" is defined with multiple arguments. One argument
@@ -193,8 +194,9 @@ type Product {
                     """
                 ],
                 [
-                    "The argument with schema coordinate 'Product.name(localization:)' has " +
-                    "inconsistent default values."
+                    "The default value '(null)' of external argument " +
+                    "'Product.name(localization:)' in schema 'B' differs from the default value " +
+                    "of '\"sr\"' in schema 'A'."
                 ]
             }
         };