Do not overwrite Id Serializer with AddGlobalObjectIdentification (#8107)

Author: tobias-tengler

src/HotChocolate/Core/src/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Relay.cs

@@ -19,7 +19,11 @@ public static partial class SchemaRequestExecutorBuilderExtensions
     public static IRequestExecutorBuilder AddGlobalObjectIdentification(
         this IRequestExecutorBuilder builder)
     {
-        builder.AddDefaultNodeIdSerializer();
+        if (builder.Services.All(t => t.ServiceType != typeof(INodeIdSerializer)))
+        {
+            builder.AddDefaultNodeIdSerializer();
+        }
+
         return builder.ConfigureSchema(c => c.AddGlobalObjectIdentification());
     }
 
@@ -39,7 +43,11 @@ public static IRequestExecutorBuilder AddGlobalObjectIdentification(
         this IRequestExecutorBuilder builder,
         bool registerNodeInterface)
     {
-        builder.AddDefaultNodeIdSerializer();
+        if (builder.Services.All(t => t.ServiceType != typeof(INodeIdSerializer)))
+        {
+            builder.AddDefaultNodeIdSerializer();
+        }
+
         return builder.ConfigureSchema(c => c.AddGlobalObjectIdentification(registerNodeInterface));
     }
 

src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeIdSerializerTests.cs

@@ -0,0 +1,42 @@
+using Microsoft.Extensions.DependencyInjection;
+
+namespace HotChocolate.Types.Relay;
+
+public class NodeIdSerializerTests
+{
+    [Fact]
+    public void Registered_NodeIdSerializer_Should_Not_Be_Overwritten_By_AddGlobalObjectIdentification()
+    {
+        // arrange
+        var provider = new ServiceCollection()
+            .AddGraphQL()
+            .AddLegacyNodeIdSerializer()
+            .AddGlobalObjectIdentification()
+            .Services.BuildServiceProvider();
+
+        // act
+        var serializer = provider.GetRequiredService<INodeIdSerializer>();
+
+        // assert
+        Assert.IsType<LegacyNodeIdSerializer>(serializer);
+    }
+
+    [Fact]
+    public void
+        Registered_DefaultNodeIdSerializer_With_OutputNewIdFormat_Should_Not_Be_Overwritten_By_AddGlobalObjectIdentification()
+    {
+        // arrange
+        var provider = new ServiceCollection()
+            .AddGraphQL()
+            .AddDefaultNodeIdSerializer(outputNewIdFormat: false)
+            .AddGlobalObjectIdentification()
+            .Services.BuildServiceProvider();
+
+        // act
+        var serializer = provider.GetRequiredService<INodeIdSerializer>();
+        var serializedId = serializer.Format("Foo", 32);
+
+        // assert
+        Assert.Equal("Rm9vCmkzMg==", serializedId);
+    }
+}