Skip to content

Commit 277f1a9

Browse files
authored
added constants and some changes to predicate class (#49)
1 parent 5d44b95 commit 277f1a9

File tree

4 files changed

+26
-24
lines changed

4 files changed

+26
-24
lines changed

src/main/java/com/checkmarx/ast/predicate/Predicate.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.checkmarx.ast.predicate;
22

3-
import com.checkmarx.ast.project.Project;
43
import com.fasterxml.jackson.annotation.JsonCreator;
54
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
65
import com.fasterxml.jackson.annotation.JsonInclude;
@@ -21,28 +20,31 @@
2120
@JsonDeserialize()
2221
@JsonInclude(JsonInclude.Include.NON_NULL)
2322
@JsonIgnoreProperties(ignoreUnknown = true)
24-
public class Predicate{
23+
public class Predicate {
2524

2625
String ID;
2726
String SimilarityID;
2827
String ProjectID;
2928
String State;
3029
String Severity;
3130
String Comment;
31+
String CreatedBy;
3232
String CreatedAt;
3333
String UpdatedAt;
3434

3535
@JsonCreator
3636
public Predicate(@JsonProperty("ID") String id, @JsonProperty("SimilarityID") String similarityID,
3737
@JsonProperty("ProjectID") String projectID, @JsonProperty("State") String state,
3838
@JsonProperty("Severity") String severity, @JsonProperty("Comment") String comment,
39-
@JsonProperty("CreatedAt") String CreatedAt, @JsonProperty("UpdatedAt") String UpdatedAt) {
39+
@JsonProperty("CreatedBy") String createdBy, @JsonProperty("CreatedAt") String CreatedAt,
40+
@JsonProperty("UpdatedAt") String UpdatedAt) {
4041
this.ID = id;
4142
this.SimilarityID = similarityID;
4243
this.ProjectID = projectID;
4344
this.State = state;
4445
this.Severity = severity;
4546
this.Comment = comment;
47+
this.CreatedBy = createdBy;
4648
this.CreatedAt = CreatedAt;
4749
this.UpdatedAt = UpdatedAt;
4850
}

src/main/java/com/checkmarx/ast/results/result/Result.java

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,30 @@
44
import com.fasterxml.jackson.annotation.JsonInclude;
55
import com.fasterxml.jackson.annotation.JsonProperty;
66
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
7-
import lombok.Value;
87

9-
@Value
8+
9+
@lombok.Data
1010
@JsonDeserialize()
1111
@JsonInclude(JsonInclude.Include.NON_NULL)
1212
@JsonIgnoreProperties(ignoreUnknown = true)
1313
public class Result {
1414

15-
String type;
16-
String id;
17-
String similarityId;
18-
String status;
19-
String state;
20-
String severity;
21-
String created;
22-
String firstFoundAt;
23-
String foundAt;
24-
String firstScan;
25-
String firstScanId;
26-
String publishedAt;
27-
String recommendations;
28-
Data data;
29-
Comments comments;
30-
VulnerabilityDetails vulnerabilityDetails;
15+
private final String type;
16+
private final String id;
17+
private final String similarityId;
18+
private final String status;
19+
private String state;
20+
private String severity;
21+
private final String created;
22+
private final String firstFoundAt;
23+
private final String foundAt;
24+
private final String firstScan;
25+
private final String firstScanId;
26+
private final String publishedAt;
27+
private final String recommendations;
28+
private final Data data;
29+
private final Comments comments;
30+
private final VulnerabilityDetails vulnerabilityDetails;
3131

3232
public Result(@JsonProperty("type") String type,
3333
@JsonProperty("id") String id,

src/main/java/com/checkmarx/ast/wrapper/CxConstants.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ public final class CxConstants {
99
public static final String SAST_PRESET_NAME = "--sast-preset-name";
1010
public static final String FILE_FILTER = "--file-filter";
1111
public static final String BRANCH = "--branch";
12-
12+
public static final String AGENT = "--agent";
1313
public static final String SAST = "sast";
14-
14+
public static final String DEBUG = "--debug";
1515
static final String CLIENT_ID = "--client-id";
1616
static final String CLIENT_SECRET = "--client-secret";
1717
static final String API_KEY = "--apikey";

src/test/java/com/checkmarx/ast/PredicateTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void testTriageUpdate() throws Exception {
4242
Result result = results.getResults().stream().filter(res -> res.getType().equalsIgnoreCase(CxConstants.SAST)).findFirst().get();
4343

4444
try {
45-
wrapper.triageUpdate(UUID.fromString(scan.getProjectID()), result.getSimilarityId(), result.getType(), "confirmed", "Edited via Java Wrapper", "high");
45+
wrapper.triageUpdate(UUID.fromString(scan.getProjectID()), result.getSimilarityId(), result.getType(), "to_verify", "Edited via Java Wrapper", "high");
4646
} catch (Exception e) {
4747
fail("Triage update failed. Should not throw exception");
4848
}

0 commit comments

Comments
 (0)