Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since v5.2.2, "api_call_facts()" changed the response of api_call_object #162

Open
duanetoler opened this issue Dec 4, 2024 · 1 comment

Comments

@duanetoler
Copy link
Contributor

Back in v5.2.2, in checkpoint.py, api_call_facts() (line 582; currently line 591 in master) was changed to transliterate the value of api_call_object from "-" to "_" on the response. However, this created inconsistency with api_call_facts_for_rule() from v5.2.2 and beyond (currently line 1438 in master). api_call_facts_for_rule() doesn't transliterate the two characters.

Will this be corrected? Of course, doing so will be a breaking change for everyone's playbooks, just as it was between v5.2.1 and v5.2.2 (when many of mine broke, like for MDS global-assignment).

@chkp-edenbr
Copy link
Contributor

Hi,
We will consider adding this to the next released version and will about the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants