Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider doing BLS ops is a worker thread #1463

Closed
dapplion opened this issue Aug 28, 2020 · 5 comments
Closed

Consider doing BLS ops is a worker thread #1463

dapplion opened this issue Aug 28, 2020 · 5 comments
Assignees
Labels
meta-discussion Indicates a topic that requires input from various developers.

Comments

@dapplion
Copy link
Contributor

BLS ops are currently very expensive. Research if it's worth it to offload some ops to a worker thread.
Pros:

  • BLS is currently synchronous, so it can block and delay time-sensitive operations
  • Consider validating deposits beforehand in group and storing the result to be consumed by the state transition.
    Cons:
  • State transition function would have to become async.
  • With native bindings, the improvements might be enough.
@dapplion dapplion added the meta-discussion Indicates a topic that requires input from various developers. label Aug 28, 2020
@wemeetagain
Copy link
Member

A few more thoughts:

  • Offloading bls to a worker may be useful when we're doing batch verification too
  • If we prevalidate deposits, we won't need to make state transition function async, we will likely run batch verification as a pre-state transition step.
  • Not all bls ops need to be worker-ized

@stale
Copy link

stale bot commented Oct 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale label Oct 28, 2020
@dapplion
Copy link
Contributor Author

unstale

@stale stale bot removed the bot:stale label Oct 29, 2020
@dapplion dapplion self-assigned this Mar 18, 2021
@dapplion
Copy link
Contributor Author

We have to wait to safely thread BLST supranational/blst#64 (comment)

However it would be valuable to start prototyping with WASM

@dapplion
Copy link
Contributor Author

Implemented in #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-discussion Indicates a topic that requires input from various developers.
Projects
None yet
Development

No branches or pull requests

2 participants