Skip to content

Clear out unsound overflows/underflows #7448

Description

@LesnyRumcajs

Summary

With the current profile we're building with, Forest will panic (and then abort) on overflow/underflow. I'm inclined to keep it for now for correctness purposes. (better fail fast rather than continue with some garbage data).

We need some safeguards, especially where users or peers are providing input.

Completion Criteria

  • Iterate over possible places where a user-supplied underflow/overflow might happen
  • harden those
  • there might be cases where the logic was blindly copied from Lotus which would do likely wrapping overflows. In case such thing is not sound, this must be reported to FilOz as well.

Additional Links & Resources

Metadata

Metadata

Assignees

Labels

Type: TaskDiscrete task to implement

Type

No type

Projects

Status
In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions