Merge from geojson-support

Author: azrogers

CHANGES.md

@@ -1,12 +1,21 @@
 # Change Log {#changes}
 
-### ? - ?
+### v2.16.1 - 2025-06-02
+
+##### Additions :tada:
+
+- Added support for `TRIANGLE_FAN` primitives in tile meshes.
 
 ##### Fixes :wrench:
 
 - Worked around an Unreal Engine limitation that prevented collisions and line traces from working correctly for tilesets with a very small scale factor.
-- Add a missing include for `GEngine` when packaging from source, introduced in *v2.16.0*.
-- Fixed a bug in UCesiumFeaturesMetadataComponent where multiple references to same feature ID set would cause improper encoding of its feature IDs.
+- Add a missing include for `GEngine` when packaging from source, introduced in `v2.16.0`.
+- Fixed a bug in `UCesiumFeaturesMetadataComponent` where multiple references to same feature ID set would cause improper encoding of its feature IDs.
+- Fixed a crash that would occur when duplicating an `ACesiumGeoreference`.
+- Fixed a bug that caused tilesets to render incorrectly when Dynamic Material Instances were used for their material settings.
+- Removed an unnecessary copy operation that happened while constructing tile meshes.
+
+In addition to the above, this release updates [cesium-native](https://github.com/CesiumGS/cesium-native) from v0.47.0 to v0.48.0. See the [changelog](https://github.com/CesiumGS/cesium-native/blob/main/CHANGES.md) for a complete list of changes in cesium-native.
 
 ### v2.16.0 - 2025-05-01
 

CesiumForUnreal.uplugin

@@ -1,7 +1,7 @@
 {
 	"FileVersion": 3,
-	"Version": 75,
-	"VersionName": "2.16.0",
+	"Version": 76,
+	"VersionName": "2.16.1",
 	"FriendlyName": "Cesium for Unreal",
 	"Description": "Unlock the 3D geospatial ecosystem in Unreal Engine with real-world 3D content and a high accuracy full-scale WGS84 globe.",
 	"Category": "Geospatial",

Content/VectorIteratorMacros.uasset

@@ -7,7 +7,7 @@ Unreal Insights can display the scope of timing events as well as activity acros
 
 # Set up a repeatable test
 
-In this example, we will use our Cesium performance tests. Follow the steps outlined [here](https://github.com/CesiumGS/cesium-unreal/blob/profiling-documentation/Documentation/performance-profiling-setup-test.md).
+In this example, we will use our Cesium performance tests. Follow the steps outlined [here](performance-profiling-setup-test.md).
 
 # Prepare for capture
 

Documentation/performance-profiling-with-unreal-insights.md

@@ -236,17 +236,20 @@ ACesiumGeoreference* ACesium3DTileset::ResolveGeoreference() {
         ACesiumGeoreference::GetDefaultGeoreferenceForActor(this);
   }
 
-  UCesium3DTilesetRoot* pRoot = Cast<UCesium3DTilesetRoot>(this->RootComponent);
-  if (pRoot) {
-    this->ResolvedGeoreference->OnGeoreferenceUpdated.AddUniqueDynamic(
-        pRoot,
-        &UCesium3DTilesetRoot::HandleGeoreferenceUpdated);
-    this->ResolvedGeoreference->OnEllipsoidChanged.AddUniqueDynamic(
-        this,
-        &ACesium3DTileset::HandleOnGeoreferenceEllipsoidChanged);
-
-    // Update existing tile positions, if any.
-    pRoot->HandleGeoreferenceUpdated();
+  if (this->ResolvedGeoreference) {
+    UCesium3DTilesetRoot* pRoot =
+        Cast<UCesium3DTilesetRoot>(this->RootComponent);
+    if (pRoot) {
+      this->ResolvedGeoreference->OnGeoreferenceUpdated.AddUniqueDynamic(
+          pRoot,
+          &UCesium3DTilesetRoot::HandleGeoreferenceUpdated);
+      this->ResolvedGeoreference->OnEllipsoidChanged.AddUniqueDynamic(
+          this,
+          &ACesium3DTileset::HandleOnGeoreferenceEllipsoidChanged);
+
+      // Update existing tile positions, if any.
+      pRoot->HandleGeoreferenceUpdated();
+    }
   }
 
   return this->ResolvedGeoreference;
@@ -1753,7 +1756,7 @@ ACesium3DTileset::CreateViewStateFromViewParameters(
   glm::dvec3 tilesetCameraUp = glm::normalize(
       glm::dvec3(unrealWorldToTileset * glm::dvec4(up.X, up.Y, up.Z, 0.0)));
 
-  return Cesium3DTilesSelection::ViewState::create(
+  return Cesium3DTilesSelection::ViewState(
       tilesetCameraLocation,
       tilesetCameraFront,
       tilesetCameraUp,

Source/CesiumRuntime/Private/Cesium3DTileset.cpp

@@ -62,10 +62,12 @@ void UCesium3DTilesetRoot::_updateAbsoluteLocation() {
 
 void UCesium3DTilesetRoot::_updateTilesetToUnrealRelativeWorldTransform() {
   ACesium3DTileset* pTileset = this->GetOwner<ACesium3DTileset>();
+  ACesiumGeoreference* pGeoreference = pTileset->ResolveGeoreference();
 
-  this->_tilesetToUnrealRelativeWorld = VecMath::createMatrix4D(
-      pTileset->ResolveGeoreference()
-          ->ComputeEarthCenteredEarthFixedToUnrealTransformation());
+  if (pGeoreference) {
+    this->_tilesetToUnrealRelativeWorld = VecMath::createMatrix4D(
+        pGeoreference->ComputeEarthCenteredEarthFixedToUnrealTransformation());
 
-  pTileset->UpdateTransformFromCesium();
+    pTileset->UpdateTransformFromCesium();
+  }
 }

Source/CesiumRuntime/Private/Cesium3DTilesetRoot.cpp

@@ -1,20 +1,27 @@
 #include "CesiumGeoJsonDocument.h"
+#include "CesiumIonServer.h"
 #include "CesiumRuntime.h"
 
-#include "CesiumUtility/Result.h"
+#include <CesiumAsync/IAssetAccessor.h>
+#include <CesiumUtility/Result.h>
 
 #include <span>
 
+FCesiumGeoJsonDocument::FCesiumGeoJsonDocument() : _pDocument(nullptr) {}
+
+FCesiumGeoJsonDocument::FCesiumGeoJsonDocument(
+    std::shared_ptr<CesiumVectorData::GeoJsonDocument>&& document)
+    : _pDocument(std::move(document)) {}
+
 bool UCesiumGeoJsonDocumentBlueprintLibrary::LoadGeoJsonFromString(
     const FString& InString,
     FCesiumGeoJsonDocument& OutVectorDocument) {
   const std::string str = TCHAR_TO_UTF8(*InString);
   std::span<const std::byte> bytes(
       reinterpret_cast<const std::byte*>(str.data()),
       str.size());
-  CesiumUtility::Result<
-      CesiumUtility::IntrusivePointer<CesiumVectorData::GeoJsonDocument>>
-      documentResult = CesiumVectorData::GeoJsonDocument::fromGeoJson(bytes);
+  CesiumUtility::Result<CesiumVectorData::GeoJsonDocument> documentResult =
+      CesiumVectorData::GeoJsonDocument::fromGeoJson(bytes);
 
   if (!documentResult.errors.errors.empty()) {
     documentResult.errors.logError(
@@ -28,9 +35,10 @@ bool UCesiumGeoJsonDocumentBlueprintLibrary::LoadGeoJsonFromString(
         "Warnings while loading GeoJSON from string");
   }
 
-  if (documentResult.pValue) {
-    OutVectorDocument =
-        FCesiumGeoJsonDocument(std::move(documentResult.pValue));
+  if (documentResult.value) {
+    OutVectorDocument = FCesiumGeoJsonDocument(
+        std::make_shared<CesiumVectorData::GeoJsonDocument>(
+            std::move(*documentResult.value)));
     return true;
   }
 
@@ -39,39 +47,94 @@ bool UCesiumGeoJsonDocumentBlueprintLibrary::LoadGeoJsonFromString(
 
 FCesiumGeoJsonObject UCesiumGeoJsonDocumentBlueprintLibrary::GetRootObject(
     const FCesiumGeoJsonDocument& InVectorDocument) {
-  if (!InVectorDocument._document) {
+  if (!InVectorDocument._pDocument) {
     return FCesiumGeoJsonObject();
   }
 
   return FCesiumGeoJsonObject(
-      InVectorDocument._document,
-      &InVectorDocument._document->getRootObject());
+      InVectorDocument._pDocument,
+      &InVectorDocument._pDocument->rootObject);
 }
 
 UCesiumLoadVectorDocumentFromIonAsyncAction*
 UCesiumLoadVectorDocumentFromIonAsyncAction::LoadFromIon(
     int64 AssetId,
-    const FString& IonAccessToken,
-    const FString& IonAssetEndpointUrl) {
+    const UCesiumIonServer* CesiumIonServer,
+    const FString& IonAccessToken) {
   UCesiumLoadVectorDocumentFromIonAsyncAction* pAction =
       NewObject<UCesiumLoadVectorDocumentFromIonAsyncAction>();
   pAction->AssetId = AssetId;
   pAction->IonAccessToken = IonAccessToken;
-  pAction->IonAssetEndpointUrl = IonAssetEndpointUrl;
+  pAction->CesiumIonServer = CesiumIonServer;
   return pAction;
 }
 
 void UCesiumLoadVectorDocumentFromIonAsyncAction::Activate() {
+  const std::string token(
+      this->IonAccessToken.IsEmpty()
+          ? TCHAR_TO_UTF8(*this->CesiumIonServer->DefaultIonAccessToken)
+          : TCHAR_TO_UTF8(*this->IonAccessToken));
   CesiumVectorData::GeoJsonDocument::fromCesiumIonAsset(
       getAsyncSystem(),
       getAssetAccessor(),
       this->AssetId,
-      TCHAR_TO_UTF8(*this->IonAccessToken),
-      TCHAR_TO_UTF8(*this->IonAssetEndpointUrl))
+      token,
+      std::string(TCHAR_TO_UTF8(*this->CesiumIonServer->ApiUrl)) + "/")
+      .thenInMainThread(
+          [Callback = this->OnLoadResult](
+              CesiumUtility::Result<CesiumVectorData::GeoJsonDocument>&&
+                  result) {
+            if (result.errors.hasErrors()) {
+              result.errors.logError(
+                  spdlog::default_logger(),
+                  "Errors loading GeoJSON:");
+              result.errors.logWarning(
+                  spdlog::default_logger(),
+                  "Warnings loading GeoJSON:");
+            }
+
+            if (result.value) {
+              Callback.Broadcast(
+                  true,
+                  FCesiumGeoJsonDocument(
+                      std::make_shared<CesiumVectorData::GeoJsonDocument>(
+                          std::move(*result.value))));
+            } else {
+              Callback.Broadcast(false, {});
+            }
+          });
+}
+
+UCesiumLoadVectorDocumentFromUrlAsyncAction*
+UCesiumLoadVectorDocumentFromUrlAsyncAction::LoadFromUrl(
+    const FString& Url,
+    const TMap<FString, FString>& Headers) {
+  UCesiumLoadVectorDocumentFromUrlAsyncAction* pAction =
+      NewObject<UCesiumLoadVectorDocumentFromUrlAsyncAction>();
+  pAction->Url = Url;
+  pAction->Headers = Headers;
+  return pAction;
+}
+
+void UCesiumLoadVectorDocumentFromUrlAsyncAction::Activate() {
+  std::vector<CesiumAsync::IAssetAccessor::THeader> requestHeaders;
+  requestHeaders.reserve(this->Headers.Num());
+
+  for (const auto& [Key, Value] : this->Headers) {
+    requestHeaders.emplace_back(CesiumAsync::IAssetAccessor::THeader{
+        TCHAR_TO_UTF8(*Key),
+        TCHAR_TO_UTF8(*Value)});
+  }
+
+  CesiumVectorData::GeoJsonDocument::fromUrl(
+      getAsyncSystem(),
+      getAssetAccessor(),
+      TCHAR_TO_UTF8(*this->Url),
+      std::move(requestHeaders))
       .thenInMainThread(
           [Callback = this->OnLoadResult](
-              CesiumUtility::Result<CesiumUtility::IntrusivePointer<
-                  CesiumVectorData::GeoJsonDocument>>&& result) {
+              CesiumUtility::Result<CesiumVectorData::GeoJsonDocument>&&
+                  result) {
             if (result.errors.hasErrors()) {
               result.errors.logError(
                   spdlog::default_logger(),
@@ -81,10 +144,12 @@ void UCesiumLoadVectorDocumentFromIonAsyncAction::Activate() {
                   "Warnings loading GeoJSON:");
             }
 
-            if (result.pValue) {
+            if (result.value) {
               Callback.Broadcast(
                   true,
-                  FCesiumGeoJsonDocument(MoveTemp(result.pValue)));
+                  FCesiumGeoJsonDocument(
+                      std::make_shared<CesiumVectorData::GeoJsonDocument>(
+                          std::move(*result.value))));
             } else {
               Callback.Broadcast(false, {});
             }