Skip to content

Commit 0a423a7

Browse files
committed
Fix CDB support tidy check line length failures.
1 parent e33c441 commit 0a423a7

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

src/test/debuginfo/pretty-std.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// ignore-freebsd: gdb package too new
2-
// only-cdb // Test temporarily ignored on GDB/LLDB due to debuginfo tests being disabled, see PR 47155
2+
// only-cdb // "Temporarily" ignored on GDB/LLDB due to debuginfo tests being disabled, see PR 47155
33
// ignore-android: FIXME(#10381)
44
// compile-flags:-g
55
// min-gdb-version 7.7
@@ -81,7 +81,7 @@
8181

8282
// cdb-command: dx str_slice
8383
// cdb-check:str_slice [...]
84-
// NOTE: While string slices have a .natvis entry that works in VS & VS Code, it fails in CDB 10.0.18362.1
84+
// NOTE: While string slices have a .natvis entry that works in VS & VS Code, it fails in CDB
8585

8686
// cdb-command: dx string
8787
// cdb-check:string : "IAMA string!" [Type: [...]::String]
@@ -110,7 +110,7 @@
110110
// cdb-command: dx none
111111
// cdb-check:none : { None } [Type: [...]::Option<i64>]
112112
// cdb-command: dx some_string
113-
// cdb-check:some_string : { Some "IAMA optional string!" } [Type: [...]::Option<[...]::String>]
113+
// cdb-check:some_string : { Some "IAMA optional string!" } [[...]::Option<[...]::String>]
114114

115115
#![allow(unused_variables)]
116116
use std::ffi::OsString;

src/tools/compiletest/src/main.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ fn find_cdb(target: &String) -> Option<OsString> {
873873

874874
let mut path = PathBuf::with_capacity(64);
875875
path.push(pf86);
876-
path.push(r"Windows Kits\10\Debuggers"); // We could check more known install locations (8.1?)
876+
path.push(r"Windows Kits\10\Debuggers"); // We could check 8.1 etc. too?
877877
path.push(cdb_arch);
878878
path.push(r"cdb.exe");
879879

src/tools/compiletest/src/runtest.rs

+5-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
use crate::common::CompareMode;
44
use crate::common::{expected_output_path, UI_EXTENSIONS, UI_FIXED, UI_STDERR, UI_STDOUT};
55
use crate::common::{output_base_dir, output_base_name, output_testname_unique};
6-
use crate::common::{Codegen, CodegenUnits, DebugInfoCdb, DebugInfoGdbLldb, DebugInfoGdb, DebugInfoLldb, Rustdoc};
6+
use crate::common::{Codegen, CodegenUnits, Rustdoc};
7+
use crate::common::{DebugInfoCdb, DebugInfoGdbLldb, DebugInfoGdb, DebugInfoLldb};
78
use crate::common::{CompileFail, Pretty, RunFail, RunPass, RunPassValgrind};
89
use crate::common::{Config, TestPaths};
910
use crate::common::{Incremental, MirOpt, RunMake, Ui, JsDocTest, Assembly};
@@ -709,7 +710,7 @@ impl<'test> TestCx<'test> {
709710
// https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/debugger-commands
710711
let mut script_str = String::with_capacity(2048);
711712
script_str.push_str("version\n"); // List CDB (and more) version info in test output
712-
script_str.push_str(".nvlist\n"); // List loaded `*.natvis` files (bulk of MSVC debugger customizations)
713+
script_str.push_str(".nvlist\n"); // List loaded `*.natvis` files, bulk of custom MSVC debug
713714

714715
// Set breakpoints on every line that contains the string "#break"
715716
let source_file_name = self.testpaths.file.file_name().unwrap().to_string_lossy();
@@ -1968,8 +1969,8 @@ impl<'test> TestCx<'test> {
19681969

19691970
rustc.arg(dir_opt);
19701971
}
1971-
RunFail | RunPassValgrind | Pretty | DebugInfoCdb | DebugInfoGdbLldb | DebugInfoGdb | DebugInfoLldb
1972-
| Codegen | Rustdoc | RunMake | CodegenUnits | JsDocTest | Assembly => {
1972+
RunFail | RunPassValgrind | Pretty | DebugInfoCdb | DebugInfoGdbLldb | DebugInfoGdb
1973+
| DebugInfoLldb | Codegen | Rustdoc | RunMake | CodegenUnits | JsDocTest | Assembly => {
19731974
// do not use JSON output
19741975
}
19751976
}

0 commit comments

Comments
 (0)