Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Tutorials examples 3a and 4a are not valid Python files #2

Open
0x00b1 opened this issue May 5, 2016 · 4 comments
Open

Tutorials examples 3a and 4a are not valid Python files #2

0x00b1 opened this issue May 5, 2016 · 4 comments

Comments

@0x00b1
Copy link
Contributor

0x00b1 commented May 5, 2016

From @anntzer on October 24, 2013 20:18

Some methods in example3a_measurements.py and example4a_skeletonizeobjects have their body entirely commented out, thus needing an extra pass statement (or turning the comments into docstrings, or commenting out the method themselves) to make them valid Python.

Copied from original issue: CellProfiler/CellProfiler#873

@0x00b1
Copy link
Contributor Author

0x00b1 commented May 5, 2016

From @LeeKamentsky on October 24, 2013 20:21

These are designed for tutorials. Part of the tutorial is uncommenting the
comments to get them to work - that's a compromise between just explaining
what each file is and having the user create the exercise file from scratch.

On Thu, Oct 24, 2013 at 4:18 PM, Antony Lee [email protected]:

Some methods in example3a_measurements.py and example4a_skeletonizeobjectshave their body entirely commented out, thus needing an extra
pass statement (or turning the comments into docstrings, or commenting
out the method themselves) to make them valid Python.


Reply to this email directly or view it on GitHubhttps://github.com/CellProfiler/CellProfiler/issues/873
.

@0x00b1
Copy link
Contributor Author

0x00b1 commented May 5, 2016

From @AnneCarpenter on October 25, 2013 11:36

Shall we add a comment to the files explaining how they are to be used, Lee?

On Thu, Oct 24, 2013 at 4:21 PM, LeeKamentsky [email protected]:

These are designed for tutorials. Part of the tutorial is uncommenting the
comments to get them to work - that's a compromise between just explaining
what each file is and having the user create the exercise file from
scratch.

On Thu, Oct 24, 2013 at 4:18 PM, Antony Lee [email protected]:

Some methods in example3a_measurements.py and
example4a_skeletonizeobjectshave their body entirely commented out, thus
needing an extra
pass statement (or turning the comments into docstrings, or commenting
out the method themselves) to make them valid Python.


Reply to this email directly or view it on GitHub<
https://github.com/CellProfiler/CellProfiler/issues/873>
.


Reply to this email directly or view it on GitHubhttps://github.com/CellProfiler/CellProfiler/issues/873#issuecomment-27026428
.

@0x00b1
Copy link
Contributor Author

0x00b1 commented May 5, 2016

From @LeeKamentsky on October 25, 2013 13:3

Fine to do, if it's in the "next" timeframe.

On Fri, Oct 25, 2013 at 7:36 AM, Anne Carpenter [email protected]:

Shall we add a comment to the files explaining how they are to be used,
Lee?

On Thu, Oct 24, 2013 at 4:21 PM, LeeKamentsky [email protected]:

These are designed for tutorials. Part of the tutorial is uncommenting
the
comments to get them to work - that's a compromise between just
explaining
what each file is and having the user create the exercise file from
scratch.

On Thu, Oct 24, 2013 at 4:18 PM, Antony Lee [email protected]:

Some methods in example3a_measurements.py and
example4a_skeletonizeobjectshave their body entirely commented out, thus
needing an extra
pass statement (or turning the comments into docstrings, or commenting
out the method themselves) to make them valid Python.


Reply to this email directly or view it on GitHub<
https://github.com/CellProfiler/CellProfiler/issues/873>
.


Reply to this email directly or view it on GitHub<
https://github.com/CellProfiler/CellProfiler/issues/873#issuecomment-27026428>

.


Reply to this email directly or view it on GitHubhttps://github.com/CellProfiler/CellProfiler/issues/873#issuecomment-27083563
.

@0x00b1
Copy link
Contributor Author

0x00b1 commented May 5, 2016

From @anntzer on October 25, 2013 17:44

OK, I was trying to repackage the git HEAD of CellProfiler for Arch Linux and the tutorial files were confusing python -m compileall. On the other hand the -x switch of compileall seems to be there exactly for that purpose, so it's fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant