srt: Consume the error from gst_srt_object_write

heftig · GStreamer Merge Bot · commit c6eeead1e4d9 · 2020-10-09T07:47:47.000Z
Instead of leaking it. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1668>
diff --git a/ext/srt/gstsrtsink.c b/ext/srt/gstsrtsink.c
@@ -178,6 +178,10 @@ gst_srt_sink_render (GstBaseSink * sink, GstBuffer * buffer)
 
   if (gst_srt_object_write (self->srtobject, self->headers, &info,
           self->cancellable, &error) < 0) {
+    GST_ELEMENT_ERROR (self, RESOURCE, WRITE,
+        ("Failed to write to SRT socket: %s",
+            error ? error->message : "Unknown error"), (NULL));
+    g_clear_error (&error);
     ret = GST_FLOW_ERROR;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,10 @@ gst_srt_sink_render (GstBaseSink * sink, GstBuffer * buffer)`
`178`	`178`
`179`	`179`	`if (gst_srt_object_write (self->srtobject, self->headers, &info,`
`180`	`180`	`self->cancellable, &error) < 0) {`
	`181`	`+ GST_ELEMENT_ERROR (self, RESOURCE, WRITE,`
	`182`	`+ ("Failed to write to SRT socket: %s",`
	`183`	`+ error ? error->message : "Unknown error"), (NULL));`
	`184`	`+ g_clear_error (&error);`
`181`	`185`	`ret = GST_FLOW_ERROR;`
`182`	`186`	`}`
`183`	`187`