Refactor request handling to use parsed URL parameters and streamline game-related endpoints

Author: CarterIrish

src/jsonResponses.js

@@ -14,8 +14,8 @@ const notFound = (request, response) => {
     sendResponse(response, 404, { message: "The endpoint you are looking for was not found", id: 'notFound' }, request.method);
 }
 
-const getGames = (request, response, parsedUrl) => {
-    const params = parsedUrl.searchParams;
+const getGames = (request, response) => {
+    const params = request.query;
 
     let games = store.getAll().map(({
         id, name, slug, url, cover, genres, platforms, rating, rating_count, first_release_date
@@ -25,36 +25,34 @@ const getGames = (request, response, parsedUrl) => {
     sendResponse(response, 200, { games }, request.method);
 }
 
-const createGame = (request, response, parsedUrl) => {
-    const params = Object.fromEntries(parsedUrl.searchParams);
-    sendResponse(response, 404, { method: request.method, path: parsedUrl.pathname, contentType: request.headers['content-type'], message: 'Work In Progress: createGame', params }, request.method);
+const createGame = (request, response) => {
+    const params = request.query;
+    sendResponse(response, 404, { method: request.method, path: response.path, contentType: request.headers['content-type'], message: 'Work In Progress: createGame', params }, request.method);
 }
 
 
-const getGame = (request, response, parsedUrl) => {
-    const parts = parsedUrl.pathname.split('/');
-    const idOrSlug = parts[3];
+const getGame = (request, response) => {
+    const { idOrSlug } = response.params;
     if (!idOrSlug) return sendResponse(response, 400, { message: 'invalid/missing params.', id: 'invalidParams' }, request.method);
     const result = isNaN(idOrSlug) ? store.getBySlug(idOrSlug) : store.getById(Number(idOrSlug));
     if (!result) return sendResponse(response, 404, { message: 'Requested resource was not found.', id: 'notFound', params: idOrSlug }, request.method);
     return sendResponse(response, 200, result, request.method);
 
 }
 
-const getGenres = (request, response, parsedUrl) => {
-    const params = Object.fromEntries(parsedUrl.searchParams);
-    sendResponse(response, 404, { method: request.method, path: parsedUrl.pathname, message: 'Work In Progress: getGenres', params }, request.method);
+const getGenres = (request, response) => {
+    const params = request.query;
+    sendResponse(response, 404, { method: request.method, path: request.path, message: 'Work In Progress: getGenres', params }, request.method);
 }
 
-const getPlatforms = (request, response, parsedUrl) => {
-    const params = Object.fromEntries(parsedUrl.searchParams);
-    sendResponse(response, 404, { method: request.method, path: parsedUrl.pathname, message: 'Work In Progress: getPlatforms', params }, request.method);
+const getPlatforms = (request, response) => {
+    const params = request.query;
+    sendResponse(response, 404, { method: request.method, path: request.path, message: 'Work In Progress: getPlatforms', params }, request.method);
 }
 
-const updateGame = (request, response, parsedUrl) => {
-    const parts = parsedUrl.pathname.split('/');
-    const idOrSlug = parts[3];
-    sendResponse(response, 404, { method: request.method, path: parsedUrl.pathname, contentType: request.headers['content-type'], message: 'Work In Progress: updateGame', idOrSlug }, request.method);
+const updateGame = (request, response) => {
+    const { idOrSlug } = response.params;
+    sendResponse(response, 404, { method: request.method, path: request.path, contentType: request.headers['content-type'], message: 'Work In Progress: updateGame', idOrSlug }, request.method);
 }
 
 module.exports = { notFound, getGames, createGame, getGame, getGenres, getPlatforms, updateGame };

src/server.js

@@ -3,6 +3,7 @@ const port = process.env.PORT || process.env.NODE_PORT || 3000;
 const htmlHandle = require('./htmlResponses');
 const jsonHandle = require('./jsonResponses');
 const { styleText } = require('node:util');
+const { get } = require('node:http');
 const URL_STRUCT = {
     '/': { GET: htmlHandle.GetIndex },
     '/docs': { GET: htmlHandle.GetDocs },
@@ -19,23 +20,29 @@ const onRequest = (request, response) => {
     const protocol = request.connection.encrypted ? 'https' : 'http';
     const parsedURL = new URL(request.url, `${protocol}://${request.headers.host}`);
 
+    request.query = Object.fromEntries(parsedURL.searchParams);
+    request.path = parsedURL.pathname;
+
+
     // TODO: Remove these 2 lines when project complete
     const consoleColor = (method === 'GET' || method === 'HEAD') ? 'green' : 'yellow';
     console.log(`${styleText(consoleColor, method)} ${request.url}`);
 
     let methodMap = URL_STRUCT[parsedURL.pathname];
     // No exact match means either 404 or dynamic endpoint ':idOrSlug'
     if (!methodMap) {
-        const parts = parsedURL.pathname.split('/');
-        if (parts.length === 4 && parts[1] === 'api' && parts[2] === 'games' && parts[3]) {
-            methodMap = { GET: jsonHandle.getGame, POST: jsonHandle.updateGame };
+        // This regex is AI generated MUST BE TAGGED IN THE DOCS!!!!!!!!
+        const regexMatch = /^\/api\/games\/(?<idOrSlug>[^/]+)$/.exec(parsedURL.pathname);
+        if(regexMatch)
+        {
+            response.params = {idOrSlug:regexMatch.groups.idOrSlug};
+            methodMap = {GET: jsonHandle.getGame, POST: jsonHandle.updateGame};
         }
-        else {
+        else{
             jsonHandle.notFound(request, response);
             return;
         }
     }
-
     const handler = methodMap[method] || jsonHandle.notFound;
     handler(request, response, parsedURL);
 }