Skip to content

[UI] Strata Table Row: Add Delete Button Functionality #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danoswaltCL opened this issue Aug 20, 2023 · 4 comments · Fixed by #1167
Closed

[UI] Strata Table Row: Add Delete Button Functionality #974

danoswaltCL opened this issue Aug 20, 2023 · 4 comments · Fixed by #1167

Comments

@danoswaltCL
Copy link
Collaborator

User Story
As an experimenter, I want to delete a strata from the database by clicking on delete in strata table row

Dependencies:
#958
#964

Links
(🟠 Link design prototype)

Image

Acceptance Criteria

GIVEN an experimenter clicks on the delete button in a strata table row
THEN they will see typical "Are you sure" speedbump modal (type delete to delete?) [ 🟠 attach design]

GIVEN they have clicked OK
THEN call delete API [ 🟠 include actual endpoint when decided] to delete the strata data by name

GIVEN this call is still pending
THEN show a spinner [ 🟠 where?]
AND nothing on page should be clickable

GIVEN the call is successful
AND the user will see a Success notification pop up [ 🟠 pic of notification 'toast' with correct text]
AND the data table will dispatch API call [ 🟠 include actual endpoint when decided] to refetch latest table data
AND the strata row will no longer show in table

GIVEN the call is error
THEN the csv will be not be downloaded
AND the user will see an error notification pop up [ 🟠 pic of notification 'toast' with correct text]
AND data table will not refetch strata data

@danoswaltCL danoswaltCL moved this to Todo in UpGrade Project Aug 20, 2023
@danoswaltCL danoswaltCL added this to the Cycle 2 (SRS) milestone Aug 20, 2023
@Yagnik56 Yagnik56 self-assigned this Aug 24, 2023
@danoswaltCL danoswaltCL moved this from Todo to Ready for Dev in UpGrade Project Aug 25, 2023
@Yagnik56 Yagnik56 linked a pull request Aug 31, 2023 that will close this issue
@Yagnik56 Yagnik56 removed a link to a pull request Aug 31, 2023
@amurphy-cl amurphy-cl moved this from Ready for Dev to In Progress in UpGrade Project Sep 5, 2023
@ppratikcr7 ppratikcr7 moved this from In Progress to QA in UpGrade Project Oct 5, 2023
@danoswaltCL danoswaltCL moved this from QA to Code Review in UpGrade Project Nov 3, 2023
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Nov 10, 2023
@zackcl zackcl self-assigned this Nov 16, 2023
@zackcl
Copy link
Collaborator

zackcl commented Nov 21, 2023

The feature functions as expected, however, the deletion of a strata takes somewhat too long, and there is no clear indication that it is being deleted. Additionally, it is possible to click the delete icon again while the row is being deleted, leading to confusion and an error. Let's discuss whether this is acceptable.

deleting.takes.too.long.mov

@bcb37
Copy link
Collaborator

bcb37 commented Nov 29, 2023

Reopening

@bcb37 bcb37 moved this from QA to Todo in UpGrade Project Nov 29, 2023
@danoswaltCL danoswaltCL moved this from Todo to In Progress in UpGrade Project Nov 30, 2023
@ppratikcr7 ppratikcr7 moved this from In Progress to Code Review in UpGrade Project Dec 7, 2023
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Dec 22, 2023
@danoswaltCL
Copy link
Collaborator Author

Re-QA: @zackcl ?

@zackcl
Copy link
Collaborator

zackcl commented Dec 22, 2023

QA: Passed

@zackcl zackcl moved this from QA to Done in UpGrade Project Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment