-
Notifications
You must be signed in to change notification settings - Fork 13
[UI] Strata Table Row: Add Delete Button Functionality #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The feature functions as expected, however, the deletion of a strata takes somewhat too long, and there is no clear indication that it is being deleted. Additionally, it is possible to click the delete icon again while the row is being deleted, leading to confusion and an error. Let's discuss whether this is acceptable. deleting.takes.too.long.mov |
Reopening |
Re-QA: @zackcl ? |
QA: Passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
As an experimenter, I want to delete a strata from the database by clicking on delete in strata table row
Dependencies:
#958
#964
Links
(🟠 Link design prototype)
Acceptance Criteria
GIVEN an experimenter clicks on the delete button in a strata table row
THEN they will see typical "Are you sure" speedbump modal (type delete to delete?) [ 🟠 attach design]
GIVEN they have clicked OK
THEN call delete API [ 🟠 include actual endpoint when decided] to delete the strata data by name
GIVEN this call is still pending
THEN show a spinner [ 🟠 where?]
AND nothing on page should be clickable
GIVEN the call is successful
AND the user will see a Success notification pop up [ 🟠 pic of notification 'toast' with correct text]
AND the data table will dispatch API call [ 🟠 include actual endpoint when decided] to refetch latest table data
AND the strata row will no longer show in table
GIVEN the call is error
THEN the csv will be not be downloaded
AND the user will see an error notification pop up [ 🟠 pic of notification 'toast' with correct text]
AND data table will not refetch strata data
The text was updated successfully, but these errors were encountered: