Skip to content

[UI] Strata Table Row: Add Download Button Functionality #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danoswaltCL opened this issue Aug 20, 2023 · 4 comments · Fixed by #1167
Closed

[UI] Strata Table Row: Add Download Button Functionality #973

danoswaltCL opened this issue Aug 20, 2023 · 4 comments · Fixed by #1167
Assignees
@Yagnik56 @zackcl @danoswaltCL
Labels
epic: stratified random sampling release 5.1
Milestone
Cycle 2 (SRS)

Comments

@danoswaltCL
Copy link
Collaborator

User Story
As an experimenter, I want to download a csv of stratification data by UUID for all in that strata row in table

Dependencies:
#958
#964

Links
(🟠 Link design prototype)

Image

Acceptance Criteria

GIVEN an experimenter clicks on the download button in a strata table row
THEN call API [ 🟠 include actual endpoint when decided] to download csv for that strata to browser

GIVEN the call is successful
THEN the csv will be downloaded
AND the user will see a Success notification pop up [ 🟠 pic of notification 'toast' with correct text]

GIVEN the call is error
THEN the csv will be not be downloaded
AND the user will see an error notification pop up [ 🟠 pic of notification 'toast' with correct text]
@danoswaltCL danoswaltCL moved this to Todo in UpGrade Project Aug 20, 2023
@danoswaltCL danoswaltCL added this to the Cycle 2 (SRS) milestone Aug 20, 2023
@Yagnik56 Yagnik56 self-assigned this Aug 24, 2023
@danoswaltCL danoswaltCL moved this from Todo to Ready for Dev in UpGrade Project Aug 25, 2023
@ppratikcr7 ppratikcr7 changed the title [UI] Strata Table Row: Add Download Button Functionaility [UI] Strata Table Row: Add Download Button Functionality Aug 29, 2023
@Yagnik56 Yagnik56 linked a pull request Aug 31, 2023 that will close this issue
Stratification Factor Feature #989
Merged
@Yagnik56 Yagnik56 removed a link to a pull request Aug 31, 2023
Stratification Factor Feature #989
Merged
@amurphy-cl amurphy-cl moved this from Ready for Dev to In Progress in UpGrade Project Sep 5, 2023
@ppratikcr7 ppratikcr7 moved this from In Progress to QA in UpGrade Project Oct 5, 2023
@danoswaltCL danoswaltCL moved this from QA to Code Review in UpGrade Project Nov 3, 2023
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Nov 10, 2023
@zackcl zackcl self-assigned this Nov 16, 2023
@zackcl
Copy link
Collaborator

zackcl commented Nov 21, 2023 •
edited
Loading

The downloading works fine, but a Success (or Error) notification pop up does not appear.
Let's discuss if we really need to display the success/error snackbar. (Related to #967 (comment))

@zackcl zackcl mentioned this issue Nov 21, 2023
Closed
@bcb37
Copy link
Collaborator

bcb37 commented Nov 29, 2023

Reopening

@bcb37 bcb37 moved this from QA to Todo in UpGrade Project Nov 29, 2023
@danoswaltCL danoswaltCL moved this from Todo to In Progress in UpGrade Project Nov 30, 2023
@Yagnik56 Yagnik56 linked a pull request Dec 7, 2023 that will close this issue
SRS factor delete and download bugfix and add notifications for delete, import and download #1167
Merged
@ppratikcr7 ppratikcr7 moved this from In Progress to Code Review in UpGrade Project Dec 7, 2023
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Dec 22, 2023
@danoswaltCL
Copy link
Collaborator Author

Re-QA: @zackcl

@zackcl
Copy link
Collaborator

zackcl commented Dec 22, 2023

QA: Passed

@zackcl zackcl moved this from QA to Done in UpGrade Project Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yagnik56 Yagnik56

@zackcl zackcl

@danoswaltCL danoswaltCL

Labels
epic: stratified random sampling release 5.1
Projects
UpGrade Project
Archived in project
Milestone
Cycle 2 (SRS)
5 participants
@bcb37 @Yagnik56 @amurphy-cl @zackcl @danoswaltCL