Skip to content

[UI] CSV Import modal: Add "Choose file" button functionality #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #956
danoswaltCL opened this issue Aug 11, 2023 · 1 comment · Fixed by #989
Closed
Tracked by #956

[UI] CSV Import modal: Add "Choose file" button functionality #966

danoswaltCL opened this issue Aug 11, 2023 · 1 comment · Fixed by #989

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Aug 11, 2023

User Story
As an experimenter, I can choose a CSV file from my computer to upload via the UI

(🟠 link to figma prototype)

Dependencies
#958
#964
#965

Links
Figma Screen Recording:
https://carnegielearning.slack.com/files/U02DS8JDP0Q/F05NH1DS0EP/screen_recording_2023-08-18_at_1.28.54_pm.mov

Acceptance Criteria
GIVEN a user clicks the "choose file" button
AND a pop-up opens with "choose file" button
THEN I will see an OS dialog to pick one csv file


[🟠 does validation need to happen in UI or after submitting?]
GIVEN a user has selected and confirmed a file in the OS dialog
THEN the csv should be validated [🟠 include validation criteria here]


[🟠 does validation need to happen in UI or after submitting?]
GIVEN that the csv is valid
THEN the UI should display [ 🟠 insert the text for a confirmation message ]
AND the button to import should be enabled


[🟠 does validation need to happen in UI or after submitting?]
GIVEN that the csv is invalid
THEN the UI should display [ 🟠 some helpful text about why it is invalid ]
AND the button to import should remain disabled


@danoswaltCL danoswaltCL added this to the Cycle 2 (SRS) milestone Aug 11, 2023
@danoswaltCL danoswaltCL moved this to Todo in UpGrade Project Aug 11, 2023
@danoswaltCL danoswaltCL changed the title UI CSV import pop-up functionality (choose file) Add UI CSV import pop-up functionality (choose file) Aug 11, 2023
@danoswaltCL danoswaltCL changed the title Add UI CSV import pop-up functionality (choose file) [UI] Add CSV import pop-up functionality (choose file) Aug 11, 2023
@danoswaltCL danoswaltCL changed the title [UI] Add CSV import pop-up functionality (choose file) [UI] CSV Import modal: Add "Choose file" button functionality Aug 14, 2023
@Yagnik56 Yagnik56 self-assigned this Aug 24, 2023
@danoswaltCL danoswaltCL moved this from Todo to Ready for Dev in UpGrade Project Aug 24, 2023
@danoswaltCL danoswaltCL moved this from Ready for Dev to In Progress in UpGrade Project Aug 25, 2023
@Yagnik56 Yagnik56 linked a pull request Aug 31, 2023 that will close this issue
@ppratikcr7 ppratikcr7 moved this from In Progress to QA in UpGrade Project Oct 5, 2023
@danoswaltCL danoswaltCL moved this from QA to Code Review in UpGrade Project Nov 3, 2023
@danoswaltCL danoswaltCL moved this from Code Review to QA in UpGrade Project Nov 10, 2023
@zackcl zackcl self-assigned this Nov 16, 2023
@zackcl
Copy link
Collaborator

zackcl commented Nov 21, 2023

QA: Passed

@zackcl zackcl moved this from QA to Done in UpGrade Project Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants