game_market ui/ux improvements

game_market ui/ux improvements
added server opcode support 238

from edubart#1027

Author: dudantas

modules/client_locales/neededtranslations.lua

@@ -284,6 +284,7 @@ neededTranslations = {
   "Position",
   "Premium",
   "Premium Account (%s) days left",
+  "Press %s button to update",
   "Price",
   "Primary",
   "Process",
@@ -320,6 +321,7 @@ neededTranslations = {
   "Secondary",
   "Select",
   "Select all",
+  "Select an item to view the offers",
   "Select object",
   "Select Outfit",
   "Select your language",

modules/game_market/market.lua

@@ -40,7 +40,6 @@ itemsPanel = nil
 selectedOffer = {}
 selectedMyOffer = {}
 
-nameLabel = nil
 feeLabel = nil
 balanceLabel = nil
 totalPriceEdit = nil
@@ -49,6 +48,8 @@ amountEdit = nil
 searchEdit = nil
 radioItemSet = nil
 selectedItem = nil
+selectedItemLabel = nil
+selectedItemTitleLabel = nil
 offerTypeList = nil
 categoryList = nil
 subCategoryList = nil
@@ -443,7 +444,9 @@ local function updateSelectedItem(widget)
   Market.resetCreateOffer()
   if Market.isItemSelected() then
     selectedItem:setItem(selectedItem.item.displayItem)
-    nameLabel:setText(selectedItem.item.marketData.name)
+    selectedItemLabel:setText('')
+    selectedItemTitleLabel:setText(selectedItem.item.marketData.name)
+    Market:hideOffersTableInstructions()
     clearOffers()
 
     Market.enableCreateOffer(true) -- update offer types
@@ -726,8 +729,10 @@ local function initMarketItems()
           }
 
           -- add new market item
+        if marketItems[marketData.category] ~= nil then
           table.insert(marketItems[marketData.category], marketItem)
           itemSet[marketData.tradeAs] = true
+        end
       end
     end
   end
@@ -741,7 +746,11 @@ local function initInterface()
 
   -- setup 'Market Offer' section tabs
   marketOffersPanel = g_ui.loadUI('ui/marketoffers')
-  mainTabBar:addTab(tr('Market Offers'), marketOffersPanel)
+  local mopTab = mainTabBar:addTab(tr('Market Offers'), marketOffersPanel)
+  mopTab.onClick = function()
+    mainTabBar:selectTab(mopTab)
+    Market.refreshOffers()
+  end
 
   selectionTabBar = marketOffersPanel:getChildById('leftTabBar')
   selectionTabBar:setContentWidget(marketOffersPanel:getChildById('leftTabContent'))
@@ -769,7 +778,11 @@ local function initInterface()
 
   -- setup 'My Offer' section tabs
   myOffersPanel = g_ui.loadUI('ui/myoffers')
-  mainTabBar:addTab(tr('My Offers'), myOffersPanel)
+  local moTab = mainTabBar:addTab(tr('My Offers'), myOffersPanel)
+  moTab.onClick = function()
+    mainTabBar:selectTab(moTab)
+    Market.refreshMyOffers()
+  end
 
   offersTabBar = myOffersPanel:getChildById('offersTabBar')
   offersTabBar:setContentWidget(myOffersPanel:getChildById('offersTabContent'))
@@ -790,8 +803,9 @@ local function initInterface()
   sellButton.onClick = function() openAmountWindow(Market.acceptMarketOffer, MarketAction.Sell, 'Sell') end
 
   -- setup selected item
-  nameLabel = marketOffersPanel:getChildById('nameLabel')
   selectedItem = marketOffersPanel:getChildById('selectedItem')
+  selectedItemLabel = selectedItem:getChildById('selectedItemLabel')
+  selectedItemTitleLabel = marketOffersPanel:getChildById('selectedItemTitleLabel')
 
   -- setup create new offer
   totalPriceEdit = marketOffersPanel:getChildById('totalPriceEdit')
@@ -917,10 +931,38 @@ function terminate()
   Market = nil
 end
 
+function Market.showMyOffersTableInstructions()
+  local instruction = tr('Press %s button to update', tr('Refresh Offers'))
+  if sellMyOfferTable then sellMyOfferTable:setText(instruction) end
+  if buyMyOfferTable then buyMyOfferTable:setText(instruction) end
+end
+
+function Market.hideMyOffersTableInstructions()
+  if sellMyOfferTable then sellMyOfferTable:setText('') end
+  if buyMyOfferTable then buyMyOfferTable:setText('') end
+end
+
+function Market.showOffersTableInstructions()
+  local instruction = tr('Select an item to view the offers')
+  if sellOfferTable then sellOfferTable:setText(instruction) end
+  if buyOfferTable then buyOfferTable:setText(instruction) end
+end
+
+function Market.hideOffersTableInstructions()
+  if sellOfferTable then sellOfferTable:setText('') end
+  if buyOfferTable then buyOfferTable:setText('') end
+end
+
+
 function Market.reset()
   balanceLabel:setColor('#bbbbbb')
   categoryList:setCurrentOption(getMarketCategoryName(MarketCategory.First))
   searchEdit:setText('')
+
+  -- When uses closes market at this screen we need to show this instruction again when it gets opened,
+  -- since we cannot load offers for the user ourselves due to the bot protection.
+  Market:showMyOffersTableInstructions()
+
   clearFilters()
   clearMyOffers()
   if not table.empty(information) then
@@ -944,11 +986,13 @@ function Market.clearSelectedItem()
 
     clearOffers()
     radioItemSet:selectWidget(nil)
-    nameLabel:setText('No item selected.')
+    Market:showOffersTableInstructions()
     selectedItem:setItem(nil)
     selectedItem.item = nil
     selectedItem.ref:setChecked(false)
     selectedItem.ref = nil
+    selectedItemLabel:setText('?')
+    selectedItemTitleLabel:setText(tr('No item selected.'))
 
     detailsTable:clearData()
     buyStatsTable:clearData()
@@ -1084,6 +1128,7 @@ function Market.refreshOffers()
 end
 
 function Market.refreshMyOffers()
+  Market:hideMyOffersTableInstructions()
   clearMyOffers()
   MarketProtocol.sendMarketBrowseMyOffers()
 end
@@ -1265,3 +1310,7 @@ end
 function Market.onMarketBrowse(offers)
   updateOffers(offers)
 end
+
+function Market.onMarketResourceBalance(balance, money)
+  return
+end

modules/game_market/marketprotocol.lua

@@ -129,6 +129,17 @@ local function parseMarketBrowse(protocol, msg)
   return true
 end
 
+local function parseMarketResourcesBalance(protocol, msg)
+  msg:getU8()
+  local balance = msg:getU64() -- bank
+  msg:getU8()
+  msg:getU8()
+  local money = msg:getU64() -- inventory
+
+  signalcall(Market.onMarketResourceBalance, balance, money)
+  return true
+end
+
 -- public functions
 function initProtocol()
   connect(g_game, { onGameStart = MarketProtocol.registerProtocol,
@@ -161,6 +172,7 @@ function MarketProtocol.registerProtocol()
     ProtocolGame.registerOpcode(GameServerOpcodes.GameServerMarketLeave, parseMarketLeave)
     ProtocolGame.registerOpcode(GameServerOpcodes.GameServerMarketDetail, parseMarketDetail)
     ProtocolGame.registerOpcode(GameServerOpcodes.GameServerMarketBrowse, parseMarketBrowse)
+    ProtocolGame.registerOpcode(GameServerOpcodes.GameServerSendResourceBalance, parseMarketResourcesBalance)
   end
   MarketProtocol.updateProtocol(g_game.getProtocolGame())
 end
@@ -171,6 +183,7 @@ function MarketProtocol.unregisterProtocol()
     ProtocolGame.unregisterOpcode(GameServerOpcodes.GameServerMarketLeave, parseMarketLeave)
     ProtocolGame.unregisterOpcode(GameServerOpcodes.GameServerMarketDetail, parseMarketDetail)
     ProtocolGame.unregisterOpcode(GameServerOpcodes.GameServerMarketBrowse, parseMarketBrowse)
+    ProtocolGame.unregisterOpcode(GameServerOpcodes.GameServerSendResourceBalance, parseMarketResourcesBalance)
   end
   MarketProtocol.updateProtocol(nil)
 end

modules/game_market/ui/general/marketcombobox.otui

@@ -15,4 +15,4 @@ MarketComboBoxPopupMenu < ComboBoxRoundedPopupMenu
 MarketComboBox < ComboBoxRounded
   font: verdana-11px-rounded
   size: 86 20
-  text-offset: 3 2
+  text-offset: 9 9

modules/game_market/ui/marketoffers.otui

@@ -39,21 +39,31 @@ Panel
     size: 34 34
     padding: 1
     font: verdana-11px-rounded
-    border-color: white
+    border-color: #535353
+    border-width: 1
     anchors.top: rightTabBar.bottom
     anchors.left: rightTabContent.left
     margin-top: 6
     margin-left: 6
 
+    Label
+      id: selectedItemLabel
+      font: verdana-11px-rounded
+      text-offset: 0 2
+      anchors.top: selectedItem.top
+      anchors.left: selectedItem.left
+      size: 34 34
+      text-align: center
+      !text: '?'
+
   Label
-    id: nameLabel
+    id: selectedItemTitleLabel
     !text: tr('No item selected.')
     font: verdana-11px-rounded
     text-offset: 0 2
-    anchors.top: prev.top
-    anchors.left: prev.right
-    anchors.right: parent.right
-    margin-left: 5
+    anchors.top: selectedItem.top
+    anchors.left: selectedItem.right
+    margin-left: 6
 
   Label
     id: createLabel

modules/game_market/ui/marketoffers/browse.otui

@@ -12,7 +12,7 @@ MarketItemBox < UICheckBox
     text-offset: 0 22
     text-align: right
     anchors.top: parent.top
-    anchors.horizontalCenter: parent.horizontalCenter
+    anchors.left: parent.left
     margin: 1
 
   $checked:
@@ -105,9 +105,7 @@ Panel
     anchors.right: parent.right
     anchors.bottom: parent.bottom
     margin-top: 10
-    margin-left: 3
     margin-bottom: 30
-    margin-right: 3
 
     VerticalScrollBar
       id: itemsPanelListScrollBar

modules/game_market/ui/marketoffers/itemoffers.otui

@@ -68,6 +68,8 @@ Panel
     column-style: OfferTableColumn
     header-column-style: false
     header-row-style: false
+    color: #cccccc
+    !text: tr('Select an item to view the offers')
 
     OfferTableHeaderRow
       id: header
@@ -141,6 +143,8 @@ Panel
     column-style: OfferTableColumn
     header-column-style: false
     header-row-style: false
+    color: #cccccc
+    !text: tr('Select an item to view the offers')
 
     OfferTableHeaderRow
       id: header
@@ -173,4 +177,4 @@ Panel
     anchors.bottom: buyingTable.bottom
     anchors.right: buyingTable.right
     step: 28
-    pixels-scroll: true
+    pixels-scroll: true

modules/game_market/ui/myoffers/currentoffers.otui

@@ -68,6 +68,8 @@ Panel
     column-style: OfferTableColumn
     header-column-style: false
     header-row-style: false
+    color: #cccccc
+    !text: tr('Press %s button to update', tr('Refresh Offers'))
 
     OfferTableHeaderRow
       id: header
@@ -141,6 +143,8 @@ Panel
     column-style: OfferTableColumn
     header-column-style: false
     header-row-style: false
+    color: #cccccc
+    !text: tr('Press %s button to update', tr('Refresh Offers'))
 
     OfferTableHeaderRow
       id: header

modules/gamelib/protocol.lua

@@ -91,6 +91,7 @@ GameServerOpcodes = {
     GameServerCoinBalance               = 223, -- 1080
     GameServerStoreError                = 224, -- 1080
     GameServerRequestPurchaseData       = 225, -- 1080
+    GameServerSendResourceBalance       = 238, -- market
     GameServerQuestLog                  = 240,
     GameServerQuestLine                 = 241,
     GameServerCoinBalanceUpdating       = 242, -- 1080

src/client/protocolcodes.h

@@ -148,6 +148,7 @@ namespace Proto {
         GameServerCoinBalance               = 223, // 1080
         GameServerStoreError                = 224, // 1080
         GameServerRequestPurchaseData       = 225, // 1080
+        GameServerSendResourceBalance       = 238, // market
         GameServerQuestLog                  = 240,
         GameServerQuestLine                 = 241,
         GameServerCoinBalanceUpdating       = 242, // 1080