Skip to content

Commit e780ad9

Browse files
committed
Reordered cone parameters.
1 parent 5dc7bba commit e780ad9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

cadquery/cq.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3803,9 +3803,9 @@ def sphere(
38033803
def cone(
38043804
self: T,
38053805
height: float,
3806-
radius: float = 0,
38073806
radius1: float = None,
38083807
radius2: float = None,
3808+
radius: float = 0,
38093809
direct: Vector = Vector(0, 0, 1),
38103810
angle: float = 360,
38113811
combine: bool = True,

tests/test_cadquery.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2482,16 +2482,21 @@ def testConeDefaults(self):
24822482
self.assertEqual(1, s.solids().size())
24832483
self.assertEqual(2, s.faces().size())
24842484
self.assertEqual(2, s.vertices().size())
2485-
s1 = Workplane("XY").cone(40, radius1=10, radius2=5)
2485+
s1 = Workplane("XY").cone(40, 10, 5)
24862486
self.assertEqual(1, s1.size())
24872487
self.assertEqual(1, s1.solids().size())
24882488
self.assertEqual(3, s1.faces().size())
24892489
self.assertEqual(2, s1.vertices().size())
2490-
s2 = Workplane("XY").cone(40, radius1=10, radius2=5, combine=False)
2490+
s2 = Workplane("XY").cone(40, radius1=10, radius2=5)
24912491
self.assertEqual(1, s2.size())
24922492
self.assertEqual(1, s2.solids().size())
24932493
self.assertEqual(3, s2.faces().size())
24942494
self.assertEqual(2, s2.vertices().size())
2495+
s3 = Workplane("XY").cone(40, radius1=10, radius2=5, combine=False)
2496+
self.assertEqual(1, s3.size())
2497+
self.assertEqual(1, s3.solids().size())
2498+
self.assertEqual(3, s3.faces().size())
2499+
self.assertEqual(2, s3.vertices().size())
24952500

24962501
def testWedgeDefaults(self):
24972502
s = Workplane("XY").wedge(10, 10, 10, 5, 5, 5, 5)

0 commit comments

Comments
 (0)