Skip to content

Commit 47025e1

Browse files
committed
utils/request.py: higher timeout for http request
1 parent 979cdc1 commit 47025e1

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

manager/knot_resolver_manager/utils/requests.py

+11-1
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,9 @@ def request(
7070
)
7171
# req.add_header("Authorization", _authorization_header)
7272

73+
timeout_m = 5 # minutes
7374
try:
74-
with urlopen(req) as response:
75+
with urlopen(req, timeout=timeout_m * 60) as response:
7576
return Response(response.status, response.read().decode("utf8"))
7677
except HTTPError as err:
7778
return Response(err.code, err.read().decode("utf8"))
@@ -83,6 +84,15 @@ def request(
8384
else:
8485
_print_conn_error(str(err), url, socket_desc.source)
8586
sys.exit(1)
87+
except TimeoutError:
88+
_print_conn_error(
89+
f"Connection timed out after {timeout_m} minutes."
90+
"\nIt does not mean that the operation necessarily failed."
91+
"\nSee Knot Resolver's log for more information.",
92+
url,
93+
socket_desc.source,
94+
)
95+
sys.exit(1)
8696

8797

8898
# Code heavily inspired by requests-unixsocket

0 commit comments

Comments
 (0)