Merge pull request #1517 from CVEProject/dr_1500_quota_unit_tests

Fixed idQuota tests

Author: jdaigneau5

src/controller/org.controller/index.js

@@ -554,8 +554,6 @@ router.get('/org/:shortname/id_quota',
   }
   */
 
-  param(['registry']).optional().isBoolean(),
-  mw.handleRegistryParameter,
   mw.validateUser,
   param(['shortname']).isString().trim().notEmpty().isLength({ min: CONSTANTS.MIN_SHORTNAME_LENGTH, max: CONSTANTS.MAX_SHORTNAME_LENGTH }),
   parseError,

test/unit-tests/org/orgGetIdQuotaTest.js

@@ -1,8 +1,10 @@
 const express = require('express')
 const app = express()
 const chai = require('chai')
+const sinon = require('sinon')
 const expect = chai.expect
 chai.use(require('chai-http'))
+const mongoose = require('mongoose')
 
 // Body Parser Middleware
 app.use(express.json()) // Allows us to handle raw JSON data
@@ -19,7 +21,22 @@ const orgFixtures = require('./mockObjects.org')
 const orgController = require('../../../src/controller/org.controller/org.controller')
 const orgParams = require('../../../src/controller/org.controller/org.middleware')
 
-describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controller', () => {
+describe('Testing the GET /org/:shortname/id_quota endpoint in Org Controller', () => {
+  let mockSession
+  beforeEach(() => {
+    mockSession = {
+      startTransaction: sinon.stub(),
+      commitTransaction: sinon.stub().resolves(),
+      abortTransaction: sinon.stub().resolves(),
+      endSession: sinon.stub().resolves()
+    }
+    sinon.stub(mongoose, 'startSession').resolves(mockSession)
+  })
+
+  afterEach(() => {
+    sinon.restore()
+  })
+
   context('Negative Tests', () => {
     it('Org with a negative id_quota was not saved', (done) => {
       const org = new Org(orgFixtures.orgWithNegativeIdQuota)
@@ -53,12 +70,17 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async isSecretariat () {
           return false
         }
+
+        async findOneByShortName () {
+          return 'microsoft'
+        }
       }
 
       app.route('/org-id_quota-not-owning-secretariat-org/:shortname')
         .get((req, res, next) => {
           const factory = {
-            getOrgRepository: () => { return new OrgNotOwnerOrSecretariatIdQuota() }
+            getOrgRepository: () => { return new OrgNotOwnerOrSecretariatIdQuota() },
+            getBaseOrgRepository: () => { return new OrgNotOwnerOrSecretariatIdQuota() }
           }
           req.ctx.repositories = factory
           next()
@@ -90,12 +112,16 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async findOneByShortName () {
           return null
         }
+
+        async getOrg () {
+          return null
+        }
       }
 
       app.route('/org-id_quota-org-does-not-exist/:shortname')
         .get((req, res, next) => {
           const factory = {
-            getOrgRepository: () => { return new OrgDoesNotExistIdQuota() }
+            getBaseOrgRepository: () => { return new OrgDoesNotExistIdQuota() }
           }
           req.ctx.repositories = factory
           next()
@@ -133,6 +159,18 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async getOrgUUID () {
           return orgFixtures.existentOrg.UUID
         }
+
+        async getOrg () {
+          return orgFixtures.existentOrg.UUID
+        }
+
+        async getOrgIdQuota () {
+          return {
+            id_quota: 1000,
+            total_reserved: 0,
+            available: 1000
+          }
+        }
       }
 
       class CveIdSecretariatIdQuota {
@@ -144,7 +182,7 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
       app.route('/org-id_quota-secretariat/:shortname')
         .get((req, res, next) => {
           const factory = {
-            getOrgRepository: () => { return new OrgSecretariatIdQuota() },
+            getBaseOrgRepository: () => { return new OrgSecretariatIdQuota() },
             getCveIdRepository: () => { return new CveIdSecretariatIdQuota() }
           }
           req.ctx.repositories = factory
@@ -181,6 +219,18 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async getOrgUUID () {
           return orgFixtures.owningOrg.UUID
         }
+
+        async getOrg () {
+          return orgFixtures.existentOrg.UUID
+        }
+
+        async getOrgIdQuota () {
+          return {
+            id_quota: 5,
+            total_reserved: 0,
+            available: 5
+          }
+        }
       }
 
       class CveIdOwnerIdQuota {
@@ -193,6 +243,7 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         .get((req, res, next) => {
           const factory = {
             getOrgRepository: () => { return new OrgOwnerIdQuota() },
+            getBaseOrgRepository: () => { return new OrgOwnerIdQuota() },
             getCveIdRepository: () => { return new CveIdOwnerIdQuota() }
           }
           req.ctx.repositories = factory
@@ -229,6 +280,18 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async getOrgUUID () {
           return orgFixtures.orgWithNegativeIdQuota.UUID
         }
+
+        async getOrg () {
+          return orgFixtures.existentOrg.UUID
+        }
+
+        async getOrgIdQuota () {
+          return {
+            id_quota: -1,
+            total_reserved: 0,
+            available: -1
+          }
+        }
       }
 
       class CveIdExceedsMinQuota {
@@ -240,7 +303,7 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
       app.route('/org-id_quota-exceeds-min-quota-limit/:shortname')
         .get((req, res, next) => {
           const factory = {
-            getOrgRepository: () => { return new OrgExceedsMinIdQuota() },
+            getBaseOrgRepository: () => { return new OrgExceedsMinIdQuota() },
             getCveIdRepository: () => { return new CveIdExceedsMinQuota() }
           }
           req.ctx.repositories = factory
@@ -277,6 +340,18 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
         async getOrgUUID () {
           return orgFixtures.orgExceedingMaxIdQuota.UUID
         }
+
+        async getOrg () {
+          return orgFixtures.existentOrg.UUID
+        }
+
+        async getOrgIdQuota () {
+          return {
+            id_quota: 100500,
+            total_reserved: 0,
+            available: 100500
+          }
+        }
       }
 
       class CveIdExceedsMaxQuota {
@@ -288,7 +363,7 @@ describe.skip('Testing the GET /org/:shortname/id_quota endpoint in Org Controll
       app.route('/org-id_quota-exceeds-max-quota-limit/:shortname')
         .get((req, res, next) => {
           const factory = {
-            getOrgRepository: () => { return new OrgExceedsMaxIdQuota() },
+            getBaseOrgRepository: () => { return new OrgExceedsMaxIdQuota() },
             getCveIdRepository: () => { return new CveIdExceedsMaxQuota() }
           }
           req.ctx.repositories = factory