-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SPARQL queries to match new ontology descriptions when new cache available #49
Comments
Some work started here CSIRO-enviro-informatics/loci-integration-api#47 |
@dr-shorthair can you comment on https://github.com/CSIRO-enviro-informatics/loci-cache-scripts/blob/master/docker/cache/resources/pre-condition-files/008_dataset_def.sparql does that need changing? I know there are somethings in there that maybe we don't need like the named individual stuff we can change that in another issue but is there anything effected by changes you know of? |
@benjaminleighton can we close this? |
I think the query that Ben pointed me at in #49 (comment) might be simplified by removing the
from each insert. From a semantic POV there is no need for this assertion. However, perhaps you guys use this classifier somewhere else in the queries? |
@jyucsiro and @dr-shorthair you are probably both in a better position to decide whether to close this and also to close out CSIRO-enviro-informatics/loci-integration-api#47 at the same time. I believe that 47 is mostly solved through another pull request you made Jonathan? Looking through that pull request here are the things to be considered:
Is there anything else that changed, structurally, that we need to account for? I'm guessing there aren't any direct dependencies in excelerator on iderdown now either but it might be worth checking with @shaneseaton . |
No description provided.
The text was updated successfully, but these errors were encountered: