Merge pull request MarimerLLC#1879 from dazinator/throw-when-sp-null

Throw exception when service provider is null on inject

Author: rockfordlhotka

Source/Csla.Shared/Reflection/ServiceProviderMethodCaller.cs

@@ -410,9 +410,11 @@ public static async Task<object> CallMethodTryAsync(object obj, ServiceProviderM
           if (method.IsInjected[index])
           {
 #if !NET40 && !NET45
-            if (service != null)
-              plist[index] = service.GetService(item.ParameterType);
-            //throw new InjectException(obj.GetType().Name + "." + info.Name + " " + Resources.MethodInjectFailed);
+            if (service == null)
+            {
+              throw new NullReferenceException(nameof(service));
+            }
+            plist[index] = service.GetService(item.ParameterType);
 
 #endif
           }

Source/csla.netcore.test/DataPortal/ServiceProviderInvocationTests.cs

@@ -41,10 +41,7 @@ public async Task NoServiceProvider()
       var obj = new TestMethods();
       var method = new ServiceProviderMethodInfo { MethodInfo = obj.GetType().GetMethod("Method1") };
       Assert.IsNotNull(method, "needed method");
-      var result = (bool)await ServiceProviderMethodCaller.CallMethodTryAsync(obj, method, new object[] { 123 });
-      Assert.IsTrue(result);
-
-     // await Assert.ThrowsExceptionAsync<InjectException>(async () => await ServiceProviderMethodCaller.CallMethodTryAsync(obj, method, new object[] { 123 }));      
+      await Assert.ThrowsExceptionAsync<NullReferenceException>(async () => await ServiceProviderMethodCaller.CallMethodTryAsync(obj, method, new object[] { 123 }));
     }
 
     [TestMethod]