fix(py): deprecate extensions sets in values (#2233)

ss2165 · web-flow · commit fe98ba10684b · 2025-05-20T09:20:16.000Z
This was missed in #1906 It was detected downstream when tket2 generated HUGRs could not be read in. We need round trip tests that go Python -> serialised -> rust -> deserialized -> Python, might need a special binding in the validation code to do this.
diff --git a/hugr-py/src/hugr/_serialization/ops.py b/hugr-py/src/hugr/_serialization/ops.py
@@ -16,7 +16,6 @@
 from .tys import (
     ConfiguredBaseModel,
     ExtensionId,
-    ExtensionSet,
     FunctionType,
     PolyFuncType,
     SumType,
@@ -109,7 +108,6 @@ class CustomValue(BaseValue):
     """An extension constant value, that can check it is of a given [CustomType]."""
 
     v: Literal["Extension"] = Field(default="Extension", title="ValueTag")
-    extensions: ExtensionSet
     typ: Type
     value: CustomConst
 
@@ -118,7 +116,6 @@ def deserialize(self) -> val.Value:
             name=self.value.c,
             typ=self.typ.deserialize(),
             val=self.value.v,
-            extensions=self.extensions,
         )
 
 
diff --git a/hugr-py/src/hugr/std/collections/array.py b/hugr-py/src/hugr/std/collections/array.py
@@ -75,9 +75,7 @@ def to_value(self) -> val.Extension:
         vs = [v._to_serial_root() for v in self.v]
         element_ty = self.ty.ty._to_serial_root()
         serial_val = {"values": vs, "typ": element_ty}
-        return val.Extension(
-            name, typ=self.ty, val=serial_val, extensions=[EXTENSION.name]
-        )
+        return val.Extension(name, typ=self.ty, val=serial_val)
 
     def __str__(self) -> str:
         return f"array({comma_sep_str(self.v)})"
diff --git a/hugr-py/src/hugr/std/collections/list.py b/hugr-py/src/hugr/std/collections/list.py
@@ -52,9 +52,7 @@ def to_value(self) -> val.Extension:
         vs = [v._to_serial_root() for v in self.v]
         element_ty = self.ty.ty._to_serial_root()
         serial_val = {"values": vs, "typ": element_ty}
-        return val.Extension(
-            name, typ=self.ty, val=serial_val, extensions=[EXTENSION.name]
-        )
+        return val.Extension(name, typ=self.ty, val=serial_val)
 
     def __str__(self) -> str:
         return f"[{comma_sep_str(self.v)}]"
diff --git a/hugr-py/src/hugr/std/collections/static_array.py b/hugr-py/src/hugr/std/collections/static_array.py
@@ -57,9 +57,7 @@ def to_value(self) -> val.Extension:
             },
             "name": self.name,
         }
-        return val.Extension(
-            "StaticArrayValue", typ=self.ty, val=serial_val, extensions=[EXTENSION.name]
-        )
+        return val.Extension("StaticArrayValue", typ=self.ty, val=serial_val)
 
     def __str__(self) -> str:
         return f"static_array({comma_sep_str(self.v)})"
diff --git a/hugr-py/src/hugr/std/collections/value_array.py b/hugr-py/src/hugr/std/collections/value_array.py
@@ -75,9 +75,7 @@ def to_value(self) -> val.Extension:
         vs = [v._to_serial_root() for v in self.v]
         element_ty = self.ty.ty._to_serial_root()
         serial_val = {"values": vs, "typ": element_ty}
-        return val.Extension(
-            name, typ=self.ty, val=serial_val, extensions=[EXTENSION.name]
-        )
+        return val.Extension(name, typ=self.ty, val=serial_val)
 
     def __str__(self) -> str:
         return f"value_array({comma_sep_str(self.v)})"
diff --git a/hugr-py/src/hugr/std/float.py b/hugr-py/src/hugr/std/float.py
@@ -25,9 +25,7 @@ class FloatVal(val.ExtensionValue):
     def to_value(self) -> val.Extension:
         name = "ConstF64"
         payload = {"value": self.v}
-        return val.Extension(
-            name, typ=FLOAT_T, val=payload, extensions=[FLOAT_TYPES_EXTENSION.name]
-        )
+        return val.Extension(name, typ=FLOAT_T, val=payload)
 
     def __str__(self) -> str:
         return f"{self.v}"
diff --git a/hugr-py/src/hugr/std/int.py b/hugr-py/src/hugr/std/int.py
@@ -66,7 +66,6 @@ def to_value(self) -> val.Extension:
             name,
             typ=int_t(self.width),
             val=payload,
-            extensions=[INT_TYPES_EXTENSION.name],
         )
 
     def __str__(self) -> str:
diff --git a/hugr-py/src/hugr/std/prelude.py b/hugr-py/src/hugr/std/prelude.py
@@ -27,7 +27,6 @@ def to_value(self) -> val.Extension:
             name,
             typ=STRING_T,
             val=payload,
-            extensions=[PRELUDE_EXTENSION.name],
         )
 
     def __str__(self) -> str:
diff --git a/hugr-py/src/hugr/val.py b/hugr-py/src/hugr/val.py
@@ -317,6 +317,8 @@ class Extension(Value):
     typ: tys.Type
     #: Value payload.
     val: Any
+
+    #: Extension set. Deprecated, no longer used. Will be removed in hugr v0.13.
     extensions: tys.ExtensionSet = field(default_factory=tys.ExtensionSet)
 
     def type_(self) -> tys.Type:
@@ -326,7 +328,6 @@ def _to_serial(self) -> sops.CustomValue:
         return sops.CustomValue(
             typ=self.typ._to_serial_root(),
             value=sops.CustomConst(c=self.name, v=self.val),
-            extensions=self.extensions,
         )
 
     def to_model(self) -> model.Term:
diff --git a/hugr-py/tests/serialization/test_extension.py b/hugr-py/tests/serialization/test_extension.py
@@ -98,7 +98,6 @@ def test_extension():
         version=SemanticVersion(0, 1, 0),
         name="ext",
         types={"foo": type_def},
-        values={},
         operations={"New": op_def},
     )
 
@@ -119,7 +118,6 @@ def test_package():
         version=SemanticVersion(0, 1, 0),
         name="ext",
         types={},
-        values={},
         operations={},
     )
     ext_load = Extension.model_validate_json(EXAMPLE)
diff --git a/specification/schema/hugr_schema_live.json b/specification/schema/hugr_schema_live.json
@@ -338,13 +338,6 @@
                     "title": "ValueTag",
                     "type": "string"
                 },
-                "extensions": {
-                    "items": {
-                        "type": "string"
-                    },
-                    "title": "Extensions",
-                    "type": "array"
-                },
                 "typ": {
                     "$ref": "#/$defs/Type"
                 },
@@ -353,7 +346,6 @@
                 }
             },
             "required": [
-                "extensions",
                 "typ",
                 "value"
             ],
diff --git a/specification/schema/hugr_schema_strict_live.json b/specification/schema/hugr_schema_strict_live.json
@@ -338,13 +338,6 @@
                     "title": "ValueTag",
                     "type": "string"
                 },
-                "extensions": {
-                    "items": {
-                        "type": "string"
-                    },
-                    "title": "Extensions",
-                    "type": "array"
-                },
                 "typ": {
                     "$ref": "#/$defs/Type"
                 },
@@ -353,7 +346,6 @@
                 }
             },
             "required": [
-                "extensions",
                 "typ",
                 "value"
             ],
diff --git a/specification/schema/testing_hugr_schema_live.json b/specification/schema/testing_hugr_schema_live.json
@@ -338,13 +338,6 @@
                     "title": "ValueTag",
                     "type": "string"
                 },
-                "extensions": {
-                    "items": {
-                        "type": "string"
-                    },
-                    "title": "Extensions",
-                    "type": "array"
-                },
                 "typ": {
                     "$ref": "#/$defs/Type"
                 },
@@ -353,7 +346,6 @@
                 }
             },
             "required": [
-                "extensions",
                 "typ",
                 "value"
             ],
diff --git a/specification/schema/testing_hugr_schema_strict_live.json b/specification/schema/testing_hugr_schema_strict_live.json
@@ -338,13 +338,6 @@
                     "title": "ValueTag",
                     "type": "string"
                 },
-                "extensions": {
-                    "items": {
-                        "type": "string"
-                    },
-                    "title": "Extensions",
-                    "type": "array"
-                },
                 "typ": {
                     "$ref": "#/$defs/Type"
                 },
@@ -353,7 +346,6 @@
                 }
             },
             "required": [
-                "extensions",
                 "typ",
                 "value"
             ],

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ def to_value(self) -> val.Extension:`
`66`	`66`	`name,`
`67`	`67`	`typ=int_t(self.width),`
`68`	`68`	`val=payload,`
`69`		`- extensions=[INT_TYPES_EXTENSION.name],`
`70`	`69`	`)`
`71`	`70`
`72`	`71`	`def __str__(self) -> str:`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ def to_value(self) -> val.Extension:`
`27`	`27`	`name,`
`28`	`28`	`typ=STRING_T,`
`29`	`29`	`val=payload,`
`30`		`- extensions=[PRELUDE_EXTENSION.name],`
`31`	`30`	`)`
`32`	`31`
`33`	`32`	`def __str__(self) -> str:`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,6 @@ def test_extension():`
`98`	`98`	`version=SemanticVersion(0, 1, 0),`
`99`	`99`	`name="ext",`
`100`	`100`	`types={"foo": type_def},`
`101`		`- values={},`
`102`	`101`	`operations={"New": op_def},`
`103`	`102`	`)`
`104`	`103`
`@@ -119,7 +118,6 @@ def test_package():`
`119`	`118`	`version=SemanticVersion(0, 1, 0),`
`120`	`119`	`name="ext",`
`121`	`120`	`types={},`
`122`		`- values={},`
`123`	`121`	`operations={},`
`124`	`122`	`)`
`125`	`123`	`ext_load = Extension.model_validate_json(EXAMPLE)`