Update StringUtils.java

BFD-3666 simpler method

Author: MahiFentaye

apps/bfd-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/V1SamhsaConsentInterceptor.java

@@ -1,6 +1,6 @@
 package gov.cms.bfd.server.war;
 
-import static gov.cms.bfd.server.war.commons.StringUtils.parseBoolean;
+import static gov.cms.bfd.server.war.commons.StringUtils.parseBooleansFromRequest;
 
 import ca.uhn.fhir.rest.api.server.RequestDetails;
 import ca.uhn.fhir.rest.server.exceptions.BaseServerResponseException;
@@ -38,12 +38,12 @@ public ConsentOutcome willSeeResource(
     logger.debug("V1SamhsaConsentInterceptor - Processing willSeeResource.");
 
     // Determine if SAMHSA filtering is required from request parameters
-    boolean excludeSAMHSAParam =
-        parseBoolean(
-            theRequestDetails.getParameters().get(AbstractResourceProvider.EXCLUDE_SAMHSA));
+    boolean excludeSamhsaParam =
+        parseBooleansFromRequest(theRequestDetails, AbstractResourceProvider.EXCLUDE_SAMHSA)
+            .getFirst();
     boolean shouldFilterSamhsa =
         CommonTransformerUtils.shouldFilterSamhsa(
-            String.valueOf(excludeSAMHSAParam), theRequestDetails);
+            String.valueOf(excludeSamhsaParam), theRequestDetails);
 
     // No filtering needed, proceed
     if (!shouldFilterSamhsa) {

apps/bfd-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/V2SamhsaConsentInterceptor.java

@@ -1,6 +1,6 @@
 package gov.cms.bfd.server.war;
 
-import static gov.cms.bfd.server.war.commons.StringUtils.parseBoolean;
+import static gov.cms.bfd.server.war.commons.StringUtils.parseBooleansFromRequest;
 
 import ca.uhn.fhir.rest.api.server.RequestDetails;
 import ca.uhn.fhir.rest.server.exceptions.BaseServerResponseException;
@@ -56,8 +56,8 @@ public ConsentOutcome willSeeResource(
 
     // Determine if SAMHSA filtering is required from request parameters
     boolean excludeSamhsaParam =
-        parseBoolean(
-            theRequestDetails.getParameters().get(AbstractResourceProvider.EXCLUDE_SAMHSA));
+        parseBooleansFromRequest(theRequestDetails, AbstractResourceProvider.EXCLUDE_SAMHSA)
+            .getFirst();
     boolean shouldFilterSamhsa =
         CommonTransformerUtils.shouldFilterSamhsa(
             String.valueOf(excludeSamhsaParam), theRequestDetails);

apps/bfd-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/StringUtils.java

@@ -42,15 +42,15 @@ public static String[] splitOnCommas(String input) {
   /**
    * Custom function to retrieve the boolean value from a string input.
    *
-   * @param input a String that needs to remove whitespace and commas.
-   * @return Split Array.
+   * @param requestDetails the request details.
+   * @param parameterToParse the parameter To Parse.
+   * @return true or false.
    */
-  public static Boolean parseBoolean(String[] input) {
-
-    return Optional.ofNullable(input)
-        .flatMap(params -> params.length > 0 ? Optional.of(params[0]) : Optional.empty())
-        .map(Boolean::parseBoolean)
-        .orElse(false);
+  public static List<Boolean> parseBooleansFromRequest(
+      RequestDetails requestDetails, String parameterToParse) {
+    return getParametersFromRequest(requestDetails, parameterToParse)
+        .map(p -> Boolean.parseBoolean(parameterToParse))
+        .toList();
   }
 
   /**