-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't mount TESP docker image #93
Comments
you set the docker image to that value on this line: https://github.com/CESNET/usegalaxy/pull/72/files#diff-9bc5553c99bc94777d9f395d0b59b4ddbbd90a213d7dae9eb86ece159e9602bdR71 I am not sure what you're expecting or going for. Could you elaborate please? |
Exactly. I think you need to remove that line and see if it works. |
@martenson We're trying to mount remote image instead of default. This line should mount remote image if it's present @martindemko I've tried both removing and leaving that parameter empty before and unfortunately it crashed both times. |
I don't remember exactly, but that is the image where the tool is supposed to work, correct? In that case, you need that image to be found using Galaxy code (that part is done and everybody uses it) and not to use some hardcoded image. AFAIK that code used @josefhandl when starting with this to simplify the implementation. I think you should remove the line and also the code handling that variable. As I mentioned before, Galaxy has the machinery to handle containers, and there already is the parameter |
What tool are you running? |
I thought we're already using galaxy machinery - I'm running fastqc. |
correct, if standard fastqc from IUC is run on qa2 it should resolve to use the biocontainer The screenshot above does not say what image was actually used it just tells you what the default values are. You need to inspect the logs to see what Galaxy resolver was looking for and what it found. |
Also looking in the admin interface of QA2 it seems you've installed fastqc with conda dependencies, which means container is not going to be used afaik |
It's showing in the log as well, however, you're right, I'll try to run it without conda |
Is there any major difference when I install fastqc through Galaxy UI (without dependencies ofc) instead of terminal?? |
@micoleaoo there shouldn't be a functional difference between using API and using UI to install a tool Given you did not install conda deps for the tool and the destination has docker enabled the following resolvers for containers are active (in order): https://github.com/CESNET/usegalaxy/blob/main/group_vars/galaxyservers.yml#L146 |
Yes, that finally worked!! Thank you for your time @martenson @martindemko |
@micoleaoo what was the change that worked? |
Sorry, forgot to elaborate. Containers in Galaxy - Main resolver types
|
default_docker_image
ingroup_vars/galaxyservers.yml
keeps defaulting tohub.cerit.io/josef_handl/tesp-test-image
even though we defined docker_enabled: truetes.py
def get_docker_image(self, job_wrapper: JobWrapper):
The text was updated successfully, but these errors were encountered: