Skip to content

Commit 0b3f22f

Browse files
kpshervazzacharo
authored andcommitted
flows: remove receivers
1 parent 08b6f04 commit 0b3f22f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1460
-1670
lines changed

cds/modules/deposit/api.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,15 @@
5656
ObjectVersion, ObjectVersionTag,
5757
as_bucket, as_object_version)
5858

59+
from ..flows.api import Flow
5960
from ..records.api import (CDSFileObject, CDSFilesIterator, CDSRecord,
6061
CDSVideosFilesIterator)
6162
from ..records.minters import doi_minter, is_local_doi, report_number_minter
6263
from ..records.resolver import record_resolver
6364
from ..records.tasks import create_symlinks
6465
from ..records.utils import lowercase_value
6566
from ..records.validators import PartialDraft4Validator
66-
from ..webhooks.status import (get_deposit_flows, get_tasks_status_by_task,
67+
from ..flows.status import (get_deposit_flows, get_tasks_status_by_task,
6768
merge_tasks_status)
6869
from .errors import DiscardConflict
6970
from .resolver import get_video_pid
@@ -931,9 +932,9 @@ def edit(self, pid=None):
931932

932933
def _clean_tasks(self):
933934
"""Clean all tasks."""
934-
events = get_deposit_flows(deposit_id=self['_deposit']['id'])
935-
for event in events:
936-
event.receiver.delete(event=event)
935+
flows = get_deposit_flows(deposit_id=self['_deposit']['id'])
936+
for flow in flows:
937+
Flow(model=flow).delete()
937938

938939
@mark_as_action
939940
def delete(self, force=True, pid=None):

cds/modules/deposit/static/js/cds_deposit/avc/avc.module.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ function cdsDepositsConfig(
102102
iiif: '/api/iiif/v2/<%=deposit%>:<%=version_id%>:<%=key%>/full/!<%=res%>/0/default.png',
103103
categories: '/api/categories',
104104
video: '/deposit/<%=deposit%>/preview/video/<%=key%>',
105-
eventInfo: '/hooks/receivers/avc/flows/<%=eventId%>',
106-
restartEvent: '/hooks/receivers/avc/flows/<%=eventId%>/tasks/<%=taskId%>',
107-
taskFeedback: '/hooks/receivers/avc/flows/<%=eventId%>/feedback',
105+
eventInfo: '/flows/<%=eventId%>',
106+
restartEvent: '/flows/<%=eventId%>/tasks/<%=taskId%>',
107+
taskFeedback: '/flows/<%=eventId%>/feedback',
108108
selfVideo: '/api/deposits/video/<%=deposit%>',
109109
bucketVideo: '/api/files/<%=bucket%>',
110110
actionVideo: '/api/deposits/video/<%=deposit%>/actions/<%=action%>',

cds/modules/deposit/static/js/cds_deposit/avc/components/cdsDeposit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ function cdsDepositCtrl(
365365
return task.info;
366366
}).map(function(task) {
367367
var payload = task.info.payload;
368-
if (payload.percentage === 100 || task.status === 'SUCCESS') {
368+
if (task.status === 'SUCCESS') {
369369
payload.completed = true;
370370
} else if (task.status === 'FAILURE') {
371371
payload.errored = true;

cds/modules/deposit/static/templates/cds_deposit/deposits.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ <h3>Click here to select videos to upload</h3>
100100
dropbox-enabled="true"
101101
dropbox-selector=".dropbox-upload"
102102
dropbox-app-key="{{ $ctrl.dropboxAppKey }}"
103-
remote-master-receiver="/api/hooks/receivers/avc/flows/"
104-
remote-children-receiver="/api/hooks/receivers/downloader/flows/"
103+
remote-master-receiver="/api/flows/"
104+
remote-children-receiver="/api/flows/"
105105
>
106106
<div class="dropbox-upload"></div>
107107
</cds-remote-uploader>
@@ -138,15 +138,15 @@ <h3>Click here to select videos to upload</h3>
138138
auto-start-upload="true"
139139
files="child._files"
140140
template="/static/templates/cds_deposit/types/video/uploader.html"
141-
remote-master-receiver="/api/hooks/receivers/avc/flows/"
141+
remote-master-receiver="/api/flows/"
142142
>
143143
<cds-remote-uploader
144144
template="/static/templates/cds_deposit/remote_upload.html"
145145
dropbox-enabled="true"
146146
dropbox-selector=".dropbox-upload"
147147
dropbox-app-key="{{ $ctrl.dropboxAppKey }}"
148-
remote-master-receiver="/api/hooks/receivers/avc/flows/"
149-
remote-children-receiver="/api/hooks/receivers/downloader/flows/"
148+
remote-master-receiver="/api/flows/"
149+
remote-children-receiver="/api/flows/"
150150
>
151151
<div class="dropbox-upload"></div>
152152
</cds-remote-uploader>

cds/modules/deposit/static/templates/cds_deposit/types/video/uploader.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<span ng-show="!f.percentage && !f.completed && !f.errored && !f.revoked"><i class="fa fa-spinner fa-spin"></i></span>
6969
<span ng-show="f.errored" class="text-danger">Error</span>
7070
<span ng-show="f.completed && !f.errored" class="text-success">Done</span>
71-
<span ng-show="f.revoked && !f.errored" class="text-warning">Not needed</span>
71+
<span ng-show="f.revoked && !f.errored" class="text-warning">Not applicable</span>
7272
</td>
7373
<td ng-show="f" class="text-center">
7474
<span ng-show="f.errored || $ctrl.cdsDepositCtrl.cdsDepositsCtrl.showAdminInterface">

cds/modules/flows/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323

2424
# as an Intergovernmental Organization or submit itself to any jurisdiction.
2525

26-
"""Invenio-Flow is a module for managing sinple backend workflows."""
26+
"""Module for managing simple backend workflows."""
2727

28-
from __future__ import absolute_import, print_function
29-
30-
from .api import Flow
31-
from .decorators import task
28+
# from __future__ import absolute_import, print_function
3229

30+
# from .api import Flow
31+
# from .decorators import task
32+
#
3333

34-
__all__ = ('Flow', 'task')
34+
# __all__ = ('Flow', 'task')

cds/modules/webhooks/_compat.py renamed to cds/modules/flows/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- coding: utf-8 -*-
22
#
33
# This file is part of Invenio.
4-
# Copyright (C) 2018 CERN.
4+
# Copyright (C) 2021 CERN.
55
#
66
# Invenio is free software; you can redistribute it
77
# and/or modify it under the terms of the GNU General Public License as

0 commit comments

Comments
 (0)