Fix error when converting empty value to id. Now return null

Author: ByScripts

composer.json

@@ -2,7 +2,6 @@
     "name": "byscripts/static-entity",
     "type": "library",
     "description": "Provide some kind of static entities",
-    "minimum-stability": "dev",
     "license": "MIT",
     "authors": [
         {

src/StaticEntityManager.php

@@ -131,7 +131,9 @@ public function hasId($id)
      */
     public function convertToId($staticEntity)
     {
-        if ($staticEntity instanceof StaticEntity) {
+        if (empty($staticEntity)) {
+            return null;
+        } elseif ($staticEntity instanceof StaticEntity) {
             return $staticEntity->getId();
         } elseif (!$this->hasId($staticEntity)) {
             throw new \Exception(

tests/StaticEntityBuilderTest.php

@@ -98,7 +98,12 @@ public function testToId()
 
         $this->assertEquals('mr', $builder->convertToId($civility));
         $this->assertEquals('mr', $builder->convertToId('mr'));
+    }
 
+    public function testEmptyToId()
+    {
+        $builder = new StaticEntityManager('\Byscripts\StaticEntity\Tests\Fixtures\Civility');
+        $this->assertNull($builder->convertToId(""));
     }
 
     /**

tests/StaticEntityTest.php

@@ -85,7 +85,11 @@ public function testToId()
 
         $this->assertEquals('mr', Civility::toId($civility));
         $this->assertEquals('mr', Civility::toId('mr'));
+    }
 
+    public function testEmptyToId()
+    {
+        $this->assertNull(Civility::toId(""));
     }
 
     /**