Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: davs2-10bit #450

Open
zhengqwe opened this issue Jan 31, 2025 · 8 comments
Open

Feature Request: davs2-10bit #450

zhengqwe opened this issue Jan 31, 2025 · 8 comments

Comments

@zhengqwe
Copy link

https://github.com/aliofwind/davs2-10bit
I tried to integrate it in my fork but failed. I'm not sure if this is related to the upstream.

@BtbN
Copy link
Owner

BtbN commented Jan 31, 2025

Are you sure FFmpeg actually supports that?
Cause there already is davs2, which is also already built here.
That repo seems to be a fork of a fork of the davs2 I'm currently building.

@zhengqwe
Copy link
Author

zhengqwe commented Feb 1, 2025

How to view ffmpeg configure log in ffbuild/config.log when using Github Action?
https://github.com/zhengqwe/FFmpeg-Builds/actions/runs/13072737352

@zhengqwe
Copy link
Author

zhengqwe commented Feb 3, 2025

Are you sure FFmpeg actually supports that?

Seem to be possible. https://github.com/xatabhk/FFmpeg-avs2-avs3
But it seems that there is no source code for compiling it, it just mentioned it used this

Cause there already is davs2, which is also already built here.

Yeah.

That repo seems to be a fork of a fork of the davs2 I'm currently building.

Yeah. The original davs2 ONLY supports 8bit videos, and does not support 10bit formats commonly used in 4K HDR videos. I'm not sure if the code here can be used normally, and more tests are required.

@BtbN
Copy link
Owner

BtbN commented Feb 3, 2025

That is a fork of FFmpeg, so adding that library here would not do any good, since I only build original upstream FFmpeg.
You'd first need to get those patches upstreamed to FFmpeg.

Also, the only difference of that fork seems to be the addition of a libuavs3e based encoder?
FFmpeg/FFmpeg@master...xatabhk:FFmpeg-avs2-avs3:master

@Fomalhaut6688
Copy link

Hope to add AVS2-10bit support

@BtbN
Copy link
Owner

BtbN commented Feb 4, 2025

Again, I won't patch FFmpeg here.
If you need a new feature like that, please first submit it upstream. It is still unclear to me if this doesn't just work.
libdavs2.c in FFmpeg looks like it generally might support 10 bit? Are you sure it doesn't just work already?

@zhengqwe
Copy link
Author

zhengqwe commented Feb 5, 2025

Hope to add AVS2-10bit support

Refer to my fork and https://github.com/xatabhk/FFmpeg-avs2-avs3
By the way, can anyone help me find the reason for building a failure? https://github.com/zhengqwe/FFmpeg-Builds/actions/runs/13072737352

@BtbN
Copy link
Owner

BtbN commented Feb 5, 2025

You are offering nonfree builds for download, that is a direct violation of the GPL.
Please stop doing that.

Besides, the only apparent difference is you re-enabling vvenc, and said nonfree builds?
master...zhengqwe:FFmpeg-Builds:master

And again, I won't carry third party FFmpeg patches here. Get them upstreamed, and I can take a look at the necessary libraries here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants