Skip to content

Commit a7595c4

Browse files
committed
Updated contribution guide and TODO.
1 parent 3d5377e commit a7595c4

File tree

2 files changed

+38
-16
lines changed

2 files changed

+38
-16
lines changed

HowTo/HOWTOPR.md

+29-11
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,40 @@
11
## How to add new topics or materials
22

3-
#### Steps
3+
#### One file to rule them all
4+
<img src="CONTENTSCREENSHOT.png" width="720">
45

5-
![Content screenshot](CONTENTSCREENSHOT.png)
6+
### How to add topics and materials
67

7-
1. Go to `RoadmapProject/Script`
8-
1. Open `Content.yml`, add topics or links to materials
9-
1. Run `main.swift`
10-
1. Commit and push all generated files and changes
11-
1. Submit a pull request
8+
1. Open `RoadmapProject/Script/Content.yml` in your fork repository
9+
1. Add topics and/or links to materials
10+
1. Commit and push `Content.yml` changes to Github
11+
2. Submit a pull request
12+
13+
#### When your changes will be applied
14+
15+
1. Wait for your pull request to be merged
16+
1. Wait up to 5 minutes for Travis CI to regenerate roadmap images and text version
1217

13-
Note. I've used Sublime text for editing YAML.
1418

15-
#### Prerequisites
19+
#### Prerequisites for adding topics and materials
1620

1721
1. Git
18-
1. Latest Swift/Xcode
1922
1. Fork of the repository
23+
2. YAML editor, e.g. [Sublime Text](https://www.sublimetext.com/).
24+
25+
### How to run generation script locally (Optional)
26+
The generation script will generate images and the text version of the roadmap.
27+
28+
1. run `./generateAll.sh`
29+
30+
**or**
31+
32+
1. Go to `RoadmapProject/Script`
33+
2. Run `./main.swift`
34+
35+
##### Prerequisites for running the script locally
36+
37+
1. Latest Swift/Xcode
2038
1. Prepare PlantUML:
2139
1. Install [JDK](http://www.oracle.com/technetwork/java/javase/downloads/jdk9-downloads-3848520.html)
2240
1. Install Homebrew:
@@ -29,7 +47,7 @@ Note. I've used Sublime text for editing YAML.
2947
1. Go to `Roadmap Project/Script/`
3048
1. Run `java -jar plantuml.jar -testdot` to check if installed correctly.
3149

32-
#### How to debug script
50+
##### How to debug script (Optional)
3351
Use `Roadmap Project/Roadmap.xcodeproj` to run and debug script.
3452

3553
Xcode runs and debugs an executable binary, thus generated output will be put next to the binary.

README.md

+9-5
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,12 @@ Roadmap of essential topics. Roadmap for all topics is [here.](RoadmapProject/Sc
3737

3838
## 🤝 How to contribute
3939

40-
- add additional topics
41-
- add missing study materials
42-
- throw ideas at me on Twitter [![Twitter URL](https://img.shields.io/twitter/url/https/twitter.com/kamranahmedse.svg?style=social&label=@bohdan_orlov)](https://twitter.com/bohdan_orlov)
40+
- add new topics to `Content.yml`
41+
- add missing study materials to `Content.yml`
42+
- throw ideas at me on [![Twitter: @PatrickKladek](https://img.shields.io/badge/twitter-@Bohdan_Orlov-4d66b3.svg?style=flat)](https://twitter.com/bohdan_orlov)
4343

44-
[Adding new topics or materials can't be easier.](HowTo/HOWTOPR.md)
44+
45+
[The complete contribution guide.](HowTo/HOWTOPR.md)
4546

4647

4748
## ☑️ TODO
@@ -54,7 +55,10 @@ Roadmap of essential topics. Roadmap for all topics is [here.](RoadmapProject/Sc
5455
- [ ] handle errors of parsing Yaml into Topics and Resources
5556
- [ ] handle file read/write errors
5657
- [ ] handle image generation errors
57-
- [ ] run the script automaticaly on PRs if the content file is changed
58+
- [x] automatic regeneration of roadmap after every commit
59+
- [ ] automatic validation of content format on PR
60+
- [ ] make sure Travis doesn't deploy if generation script fails
61+
5862
## License
5963

6064
[![License: CC BY 4.0](https://img.shields.io/badge/License-CC%20BY%204.0-lightgrey.svg)](https://creativecommons.org/licenses/by/4.0/)

0 commit comments

Comments
 (0)