Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Gadomancy #95

Open
HellFirePvP opened this issue Nov 26, 2015 · 1 comment
Open

Incompatibility with Gadomancy #95

HellFirePvP opened this issue Nov 26, 2015 · 1 comment

Comments

@HellFirePvP
Copy link

Greetings,

I and makeo are the developers of Gadomancy
curseforge project page: http://minecraft.curseforge.com/projects/gadomancy
github: https://github.com/makeoo/Gadomancy

The issue is, we got an imcompatibility issue with your mod on our side which we can't fix.

Issue: makeo/Gadomancy#34

Basically what's happening: You're checking for TileEntity.getClass().equals(TileNode.class) at some points in your code. The problem is, we're adding a new kind of nodetype and are overwriting the BlockAiry of Thaumcraft to be able to add our tileentities instead of the default thaumcraft ones. So every Node has the TileEntity "TileExtendedNode" (path: makeoo.gadomancy.common.blocks.tiles.TileExtendedNode) and thus tileentity.getClass().equals(TileNode.class) is always false, which is not the case for modpacks where only TC is installed. Unfortunately we cannot do anything about this on our end, so i'd ask you to change your code from "tileentity.getClass().equals(TileNode.class)" to "tileentity instanceof INode" or related. That's not only compatible with our mod, it would also support any other kind of mod that adds its own nodes or whatsoever.

Overall, that's not that big of an issue code-wise, so resolving it as soon as possible would be really awesome!

~HellFirePvP

@BluSunrize
Copy link
Owner

I'll see to it when I actually work on WG again. Warning: Might be a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants