-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Covetous coin doesn't seem to work with Tinker's Construct lapis? #71
Comments
Since I noticed that Beserker's Bracers dont work either I think it simply has something to do with tinkers tools&weapons and how they work. |
Probably because they don't seem to use actual enchantments for the tools. The modifiers affect the tool attributes more directly. |
Actually, Fortune, Looting and Silk touch are all placed on tinkers tools in the proper conditions, so they do use actual enchantments in some cases. |
No, they use separate code from the Vanilla code to create Silk Touch, Fortune, etc, which is most likely incompatible with this. |
The silk touch, looting and fortune enchantments themselves are placed on the tools when you upgrade them with the jewel/enough lapis, as actual enchantments (Check the NBT), likely done because silk touch & fortune/looting are handled by the blocks & entities themselves, so adding the enchants is how tinkers makes it work, even if the way you get those enchantments on the tools (modifiers) is different. |
The Tinker's Construct Wikia claims otherwise: |
I'm sorry: https://github.com/SlimeKnights/TinkersConstruct/blob/1.7.10/src/main/java/tconstruct/modifiers/tools/ModLapis.java#L92 |
This is sort of speculative, because it's hard to measure, but my general impression has been that a 450 lapis Tinker's Construct tool does indeed have the same Looting III that you'd get from enchantment. However, the Ring of the Covetous Coin seems to work fine on items with the Looting III enchantment per se, but does not seem to work on Tinker's Construct gear. Not sure whether this is even real; my basis is just counting amber from mining a stack or two with a fortune 3 pickaxe and a fortune 3 TiC pickaxe.
The text was updated successfully, but these errors were encountered: