Skip to content

Commit 88d76e9

Browse files
committed
As per discussion #337, the default of cparams.splitmode is now AUTO_SPLIT. See #338 though.
1 parent 08699bb commit 88d76e9

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/blosc2/storage.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class CParams:
5959
blosc2 will choose the size automatically.
6060
splitmode: :class:`SplitMode`
6161
The split mode for the blocks.
62-
The default value is :py:obj:`SplitMode.ALWAYS_SPLIT <SplitMode>`.
62+
The default value is :py:obj:`SplitMode.AUTO_SPLIT <SplitMode>`.
6363
filters: :class:`Filter` or int list
6464
The sequence of filters. Default: [:py:obj:`Filter.NOFILTER <Filter>`,
6565
:py:obj:`Filter.NOFILTER <Filter>`, :py:obj:`Filter.NOFILTER <Filter>`, :py:obj:`Filter.NOFILTER <Filter>`,
@@ -77,7 +77,7 @@ class CParams:
7777
typesize: int = 8
7878
nthreads: int = field(default_factory=default_nthreads)
7979
blocksize: int = 0
80-
splitmode: blosc2.SplitMode = blosc2.SplitMode.ALWAYS_SPLIT
80+
splitmode: blosc2.SplitMode = blosc2.SplitMode.AUTO_SPLIT
8181
filters: list[blosc2.Filter | int] = field(default_factory=default_filters)
8282
filters_meta: list[int] = field(default_factory=default_filters_meta)
8383
tuner: blosc2.Tuner = blosc2.Tuner.STUNE

tests/ndarray/test_lossy.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@
2525
False,
2626
),
2727
(
28+
# For some reason, ZFP needs to always split buffers in this test
2829
(100, 1230),
2930
np.float64,
30-
{"codec": blosc2.Codec.ZFP_ACC, "codec_meta": 37},
31+
{"codec": blosc2.Codec.ZFP_ACC, "codec_meta": 37, "splitmode": blosc2.SplitMode.ALWAYS_SPLIT},
3132
None,
3233
False,
3334
),
@@ -39,9 +40,10 @@
3940
True,
4041
),
4142
(
43+
# For some reason, ZFP needs to always split buffers in this test
4244
(80, 51, 60),
4345
np.float32,
44-
{"codec": blosc2.Codec.ZFP_RATE, "codec_meta": 37},
46+
{"codec": blosc2.Codec.ZFP_RATE, "codec_meta": 37, "splitmode": blosc2.SplitMode.ALWAYS_SPLIT},
4547
"lossy.b2nd",
4648
False,
4749
),

tests/test_storage.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def test_cparams_defaults():
124124
cparams = blosc2.CParams()
125125
assert cparams.codec == blosc2.Codec.ZSTD
126126
assert cparams.codec_meta == 0
127-
assert cparams.splitmode == blosc2.SplitMode.ALWAYS_SPLIT
127+
assert cparams.splitmode == blosc2.SplitMode.AUTO_SPLIT
128128
assert cparams.clevel == 1
129129
assert cparams.typesize == 8
130130
assert cparams.nthreads == blosc2.nthreads

0 commit comments

Comments
 (0)