Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Request; Automatic caching of newly added files #749

Open
Xterionix opened this issue Feb 19, 2025 · 7 comments · May be fixed by #755
Open

Feature/Request; Automatic caching of newly added files #749

Xterionix opened this issue Feb 19, 2025 · 7 comments · May be fixed by #755
Assignees
Labels
enhancement New feature or request

Comments

@Xterionix
Copy link
Contributor

Xterionix commented Feb 19, 2025

Is your feature request related to a problem? Please describe.
I've frequently had to export stuff like animations from blockbench and then open those files and save them in vscode so that they are recognized by the extension.

Describe the solution you'd like
It'd be nice if the extension ran through the scan it does just for newly added files and saves whatever data it needs

@DaanV2
Copy link
Contributor

DaanV2 commented Feb 19, 2025

hmmm this should just work, vscode triggers document events when they are added 🤔 or is just saved...

Agree that this should be just working

@Xterionix
Copy link
Contributor Author

If you could point to where this is setup, I could look into it when I get the chance. But it seems to be only on save

@Xterionix
Copy link
Contributor Author

The extension api does have file watchers so you might be able to use that if you aren't already

@DaanV2
Copy link
Contributor

DaanV2 commented Feb 19, 2025

This class should be responsible:

@Xterionix
Copy link
Contributor Author

Well, I'm not sure what's going on

@DaanV2
Copy link
Contributor

DaanV2 commented Mar 1, 2025

Well, I'm not sure what's going on

As in you add everything but vscode is not triggering anything or?

If you could open a PR, I can take a look with you :)

@Xterionix
Copy link
Contributor Author

As in, I'm not really sure how the code works so I can't really figure out anything

@DaanV2 DaanV2 linked a pull request Mar 3, 2025 that will close this issue
1 task
@DaanV2 DaanV2 self-assigned this Mar 3, 2025
@DaanV2 DaanV2 added the enhancement New feature or request label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants