Skip to content

Commit c050ef0

Browse files
committed
Messagetype attack mitigation
- temporarily restrict messagetypes - use a new "Contact support" address
1 parent 4cd36ec commit c050ef0

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/bitmessageqt/support.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
from version import softwareVersion
2222

2323
# this is BM support address going to Peter Surda
24-
SUPPORT_ADDRESS = 'BM-2cTkCtMYkrSPwFTpgcBrMrf5d8oZwvMZWK'
24+
OLD_SUPPORT_ADDRESS = 'BM-2cTkCtMYkrSPwFTpgcBrMrf5d8oZwvMZWK'
25+
SUPPORT_ADDRESS = 'BM-2cUdgkDDAahwPAU6oD2A7DnjqZz3hgY832'
2526
SUPPORT_LABEL = 'PyBitmessage support'
2627
SUPPORT_MY_LABEL = 'My new address'
2728
SUPPORT_SUBJECT = 'Support request'
@@ -53,6 +54,7 @@
5354
'''
5455

5556
def checkAddressBook(myapp):
57+
sqlExecute('''DELETE from addressbook WHERE address=?''', OLD_SUPPORT_ADDRESS)
5658
queryreturn = sqlQuery('''SELECT * FROM addressbook WHERE address=?''', SUPPORT_ADDRESS)
5759
if queryreturn == []:
5860
sqlExecute('''INSERT INTO addressbook VALUES (?,?)''', str(QtGui.QApplication.translate("Support", SUPPORT_LABEL)), SUPPORT_ADDRESS)

src/messagetypes/__init__.py

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ def encode(self):
1111

1212

1313
def constructObject(data):
14+
whitelist = ["message"]
15+
if data[""] not in whitelist:
16+
return None
1417
try:
1518
m = import_module("messagetypes." + data[""])
1619
classBase = getattr(m, data[""].title())

0 commit comments

Comments
 (0)