Merge branch '3.4'

* 3.4:
  [Console] Add protected static $defaultName to set the default name of a Command
  removed sf2 references
  [Console] Allow commands to provide a default name for compile time registration
  [DI] Case sensitive parameter names

Author: nicolas-grekas

src/Symfony/Bridge/Twig/Command/DebugCommand.php

@@ -26,6 +26,8 @@
  */
 class DebugCommand extends Command
 {
+    protected static $defaultName = 'debug:twig';
+
     private $twig;
 
     public function __construct(Environment $twig)
@@ -38,7 +40,6 @@ public function __construct(Environment $twig)
     protected function configure()
     {
         $this
-            ->setName('debug:twig')
             ->setDefinition(array(
                 new InputArgument('filter', InputArgument::OPTIONAL, 'Show details for all entries matching this filter'),
                 new InputOption('format', null, InputOption::VALUE_REQUIRED, 'The output format (text or json)', 'text'),

src/Symfony/Bridge/Twig/Command/LintCommand.php

@@ -31,6 +31,8 @@
  */
 class LintCommand extends Command
 {
+    protected static $defaultName = 'lint:twig';
+
     private $twig;
 
     public function __construct(Environment $twig)
@@ -43,7 +45,6 @@ public function __construct(Environment $twig)
     protected function configure()
     {
         $this
-            ->setName('lint:twig')
             ->setDescription('Lints a template and outputs encountered errors')
             ->addOption('format', null, InputOption::VALUE_REQUIRED, 'The output format', 'txt')
             ->addArgument('filename', InputArgument::IS_ARRAY)

src/Symfony/Bridge/Twig/composer.json

@@ -39,7 +39,8 @@
         "symfony/web-link": "~3.4|~4.0"
     },
     "conflict": {
-        "symfony/form": "<3.4"
+        "symfony/form": "<3.4",
+        "symfony/console": "<3.4"
     },
     "suggest": {
         "symfony/finder": "",

src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php

@@ -29,15 +29,14 @@
  */
 class AboutCommand extends Command
 {
+    protected static $defaultName = 'about';
+
     /**
      * {@inheritdoc}
      */
     protected function configure()
     {
-        $this
-            ->setName('about')
-            ->setDescription('Displays information about the current project')
-        ;
+        $this->setDescription('Displays information about the current project');
     }
 
     /**

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

@@ -36,6 +36,8 @@ class AssetsInstallCommand extends Command
     const METHOD_ABSOLUTE_SYMLINK = 'absolute symlink';
     const METHOD_RELATIVE_SYMLINK = 'relative symlink';
 
+    protected static $defaultName = 'assets:install';
+
     private $filesystem;
 
     public function __construct(Filesystem $filesystem)
@@ -51,7 +53,6 @@ public function __construct(Filesystem $filesystem)
     protected function configure()
     {
         $this
-            ->setName('assets:install')
             ->setDefinition(array(
                 new InputArgument('target', InputArgument::OPTIONAL, 'The target directory', 'public'),
             ))

src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php

@@ -32,6 +32,8 @@
  */
 class CacheClearCommand extends Command
 {
+    protected static $defaultName = 'cache:clear';
+
     private $cacheClearer;
     private $filesystem;
 
@@ -53,7 +55,6 @@ public function __construct(CacheClearerInterface $cacheClearer, Filesystem $fil
     protected function configure()
     {
         $this
-            ->setName('cache:clear')
             ->setDefinition(array(
                 new InputOption('no-warmup', '', InputOption::VALUE_NONE, 'Do not warm up the cache'),
                 new InputOption('no-optional-warmers', '', InputOption::VALUE_NONE, 'Skip optional cache warmers (faster)'),

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

@@ -26,6 +26,8 @@
  */
 final class CachePoolClearCommand extends Command
 {
+    protected static $defaultName = 'cache:pool:clear';
+
     private $poolClearer;
 
     public function __construct(Psr6CacheClearer $poolClearer)
@@ -41,7 +43,6 @@ public function __construct(Psr6CacheClearer $poolClearer)
     protected function configure()
     {
         $this
-            ->setName('cache:pool:clear')
             ->setDefinition(array(
                 new InputArgument('pools', InputArgument::IS_ARRAY | InputArgument::REQUIRED, 'A list of cache pools or cache pool clearers'),
             ))

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolPruneCommand.php

@@ -24,6 +24,8 @@
  */
 final class CachePoolPruneCommand extends Command
 {
+    protected static $defaultName = 'cache:pool:prune';
+
     private $pools;
 
     /**
@@ -42,7 +44,6 @@ public function __construct($pools)
     protected function configure()
     {
         $this
-            ->setName('cache:pool:prune')
             ->setDescription('Prune cache pools')
             ->setHelp(<<<'EOF'
 The <info>%command.name%</info> command deletes all expired items from all pruneable pools.

src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php

@@ -27,6 +27,8 @@
  */
 class CacheWarmupCommand extends Command
 {
+    protected static $defaultName = 'cache:warmup';
+
     private $cacheWarmer;
 
     public function __construct(CacheWarmerAggregate $cacheWarmer)
@@ -42,7 +44,6 @@ public function __construct(CacheWarmerAggregate $cacheWarmer)
     protected function configure()
     {
         $this
-            ->setName('cache:warmup')
             ->setDefinition(array(
                 new InputOption('no-optional-warmers', '', InputOption::VALUE_NONE, 'Skip optional cache warmers (faster)'),
             ))

src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php

@@ -28,13 +28,14 @@
  */
 class ConfigDebugCommand extends AbstractConfigCommand
 {
+    protected static $defaultName = 'debug:config';
+
     /**
      * {@inheritdoc}
      */
     protected function configure()
     {
         $this
-            ->setName('debug:config')
             ->setDefinition(array(
                 new InputArgument('name', InputArgument::OPTIONAL, 'The bundle name or the extension alias'),
                 new InputArgument('path', InputArgument::OPTIONAL, 'The configuration option path'),