Skip to content

Commit 8527c11

Browse files
committed
minor PHP-CS-Fixer#4691 Run Travis CI on stable PHP 7.4 (kubawerlos)
This PR was merged into the 2.15 branch. Discussion ---------- Run Travis CI on stable PHP 7.4 - "Static Code Analysis" and "Fast Test" to be run on PHP 7.4 - each standard job to be run on different PHP (previously "Collect coverage" and "With migration rules" were run on the same PHP version) - `nightly` instead of `7.4snapshot` as `assertUpcomingPhpVersionIsCoveredByCiJob` - allow nightly to fail - update `humbug/box` due to it's dependency `nikic/iter` having the [problem](https://github.com/nikic/iter/blob/v1.6.0/src/iter.fn.php#L3) with PHP 7.4 Needs https://travis-ci.community/t/some-extensions-are-missing-in-php-7-4-0-zip-gmp-sodium/6320 to be fixed Commits ------- 9f93a51 DX: run Travis CI on stable PHP 7.4
2 parents 3b25833 + 9f93a51 commit 8527c11

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

.travis.yml

+12-7
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
include:
2626
-
2727
stage: Static Code Analysis
28-
php: 7.3
28+
php: 7.4
2929
env: COMPOSER_FLAGS="--prefer-stable"
3030
install:
3131
- travis_retry ./dev-tools/install.sh
@@ -81,12 +81,14 @@ jobs:
8181
<<: *STANDARD_TEST_JOB
8282
stage: Test
8383
php: 7.1
84+
name: 7.1 | Symfony 4.1
8485
env: SYMFONY_DEPRECATIONS_HELPER=disabled PHP_CS_FIXER_TEST_USE_LEGACY_TOKENIZER=1 SYMFONY_VERSION="~4.1.0"
8586

8687
-
8788
<<: *STANDARD_TEST_JOB
8889
stage: Test
8990
php: 7.2
91+
name: 7.2 | Symfony 5.0
9092
env: SYMFONY_DEPRECATIONS_HELPER=disabled PHP_CS_FIXER_TEST_USE_LEGACY_TOKENIZER=1 SYMFONY_VERSION="^5.0"
9193

9294
-
@@ -95,13 +97,13 @@ jobs:
9597
php: 7.3
9698
name: 7.3 | With migration rules
9799
before_script:
98-
- php php-cs-fixer fix --rules @PHP71Migration,@PHP71Migration:risky,blank_line_after_opening_tag -q || travis_terminate 1
100+
- php php-cs-fixer fix --rules @PHP73Migration,@PHP71Migration:risky,blank_line_after_opening_tag -q || travis_terminate 1
99101

100102
-
101103
<<: *STANDARD_TEST_JOB
102104
stage: Test
103-
php: 7.3
104-
name: 7.3 | Collect coverage
105+
php: 7.4
106+
name: 7.4 | Collect coverage
105107
before_install:
106108
# for building a tag release we don't need to collect code coverage
107109
- if [ $TRAVIS_TAG ]; then travis_terminate 0; fi
@@ -118,7 +120,7 @@ jobs:
118120

119121
# Install PCOV
120122
- |
121-
git clone --single-branch --branch=v1.0.2 --depth=1 https://github.com/krakjoe/pcov
123+
git clone --single-branch --branch=v1.0.6 --depth=1 https://github.com/krakjoe/pcov
122124
cd pcov
123125
phpize
124126
./configure
@@ -135,12 +137,12 @@ jobs:
135137
-
136138
<<: *STANDARD_TEST_JOB
137139
stage: Test
138-
php: 7.4snapshot
140+
php: nightly
139141
env: COMPOSER_FLAGS="--ignore-platform-reqs" PHP_CS_FIXER_IGNORE_ENV=1 SYMFONY_DEPRECATIONS_HELPER=weak
140142

141143
-
142144
stage: Deployment
143-
php: 7.3
145+
php: 7.4
144146
install: ./dev-tools/build.sh
145147
script:
146148
- PHP_CS_FIXER_TEST_ALLOW_SKIPPING_SMOKE_TESTS=0 vendor/bin/phpunit tests/Smoke/
@@ -159,3 +161,6 @@ jobs:
159161
tags: true
160162
after_deploy:
161163
- ./dev-tools/trigger-website.sh ${TRAVIS_TOKEN} ${TRAVIS_TAG}
164+
165+
allow_failures:
166+
- php: nightly

dev-tools/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"php": "^7.1"
44
},
55
"require-dev": {
6-
"humbug/box": "~3.7.0",
6+
"humbug/box": "^3.8",
77
"localheinz/composer-normalize": "^1.1",
88
"mi-schi/phpmd-extension": "^4.3",
99
"phpmd/phpmd": "^2.6",

phpstan.neon

-2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,4 @@ parameters:
1111
ignoreErrors:
1212
- '/^.+::__construct\(\) does not call parent constructor from SplFileInfo\.$/'
1313
- '/^Return typehint of method PhpCsFixer\\Tests\\Test\\.+::createIsIdenticalStringConstraint\(\) has invalid type PHPUnit_Framework_Constraint_IsIdentical\.$/'
14-
## cannot analyse out of PHP 7.4
15-
- '/^Constant T_FN not found\.$/'
1614
- '/^Class (Symfony\\Contracts\\EventDispatcher\\Event|Symfony\\Component\\EventDispatcher\\Event) not found.$/'

0 commit comments

Comments
 (0)