chore(express): convert post to get and add logs

TICKET: WP-4376

Author: pranavjain97

modules/express/src/clientRoutes.ts

@@ -1771,8 +1771,9 @@ export function setupSigningRoutes(app: express.Application, config: Config): vo
   );
 }
 
-export function setupEnclavedSigningRoutes(app: express.Application, config: Config): void {
-  app.post('/ping/enclavedExpress', parseBody, prepareBitGo(config), promiseWrapper(handlePingEnclavedExpress));
+export function setupEnclavedExpressRoutes(app: express.Application, config: Config): void {
+  // Keep the ping endpoint for health checks
+  app.get('/ping/enclavedExpress', parseBody, prepareBitGo(config), promiseWrapper(handlePingEnclavedExpress));
 }
 
 export function setupLightningSignerNodeRoutes(app: express.Application, config: Config): void {

modules/express/src/enclavedExpressRoutes/enclavedExpressRoutes.ts

@@ -4,12 +4,13 @@ import * as express from 'express';
 import { retryPromise } from '../retryPromise';
 
 export async function handlePingEnclavedExpress(req: express.Request) {
+  console.log('Making enclaved express request with SSL cert to:', req.config?.enclavedExpressUrl);
   return await retryPromise(
     () =>
       superagent
-        .post(`${req.config?.enclavedExpressUrl}/ping`)
+        .get(`${req.config?.enclavedExpressUrl}/ping`)
         .ca(req.config?.enclavedExpressSSLCert as string)
-        .send({}),
+        .send(),
     (err, tryCount) => {
       debug(`Failed to ping enclavedExpress: ${err.message}`);
     }

modules/express/src/expressApp.ts

@@ -287,7 +287,7 @@ export function setupRoutes(app: express.Application, config: Config): void {
   if (config.signerMode) {
     clientRoutes.setupSigningRoutes(app, config);
   } else if (config.enclavedExpressUrl && config.enclavedExpressSSLCert) {
-    clientRoutes.setupEnclavedSigningRoutes(app, config);
+    clientRoutes.setupEnclavedExpressRoutes(app, config);
   } else {
     if (config.lightningSignerFileSystemPath) {
       clientRoutes.setupLightningSignerNodeRoutes(app, config);

modules/express/test/unit/config.ts

@@ -83,6 +83,8 @@ describe('Config:', () => {
       customrooturi: 'argcustomRootUri',
       custombitcoinnetwork: 'argcustomBitcoinNetwork',
       externalSignerUrl: 'argexternalSignerUrl',
+      enclavedExpressUrl: 'argenclavedExpressUrl',
+      enclavedExpressSSLCert: 'argenclavedExpressSSLCert',
       signerMode: 'argsignerMode',
       signerFileSystemPath: 'argsignerFileSystemPath',
       lightningSignerFileSystemPath: 'arglightningSignerFileSystemPath',
@@ -107,6 +109,8 @@ describe('Config:', () => {
       BITGO_CUSTOM_ROOT_URI: 'envcustomRootUri',
       BITGO_CUSTOM_BITCOIN_NETWORK: 'envcustomBitcoinNetwork',
       BITGO_EXTERNAL_SIGNER_URL: 'envexternalSignerUrl',
+      BITGO_ENCLAVED_EXPRESS_URL: 'envenclavedExpressUrl',
+      BITGO_ENCLAVED_EXPRESS_SSL_CERT: 'envenclavedExpressSSLCert',
       BITGO_SIGNER_MODE: 'envsignerMode',
       BITGO_SIGNER_FILE_SYSTEM_PATH: 'envsignerFileSystemPath',
       BITGO_LIGHTNING_SIGNER_FILE_SYSTEM_PATH: 'envlightningSignerFileSystemPath',
@@ -132,6 +136,8 @@ describe('Config:', () => {
       customBitcoinNetwork: 'argcustomBitcoinNetwork',
       authVersion: 2,
       externalSignerUrl: 'https://argexternalSignerUrl',
+      enclavedExpressUrl: 'https://argenclavedExpressUrl',
+      enclavedExpressSSLCert: 'argenclavedExpressSSLCert',
       signerMode: 'argsignerMode',
       signerFileSystemPath: 'argsignerFileSystemPath',
       lightningSignerFileSystemPath: 'arglightningSignerFileSystemPath',