refactor(utxo-core): refactored tests

Ticket: BTC-2235

TICKET: BTC-2235

Author: christopher-fong

modules/utxo-core/test/paygo/psbt/payGoAddressProof.ts

@@ -15,7 +15,7 @@ import {
 import { generatePayGoAttestationProof } from '../../../src/testutil/generatePayGoAttestationProof.utils';
 import { trimMessagePrefix } from '../../../src/paygo/trimMessagePrefix';
 import { signMessage } from '../../../src/bip32utils';
-import { NIL_UUID } from '../../../src/paygo/attestation';
+import { createPayGoAttestationBuffer, NIL_UUID } from '../../../src/paygo/attestation';
 import { parsePayGoAttestation } from '../../../src/paygo';
 
 // To construct our PSBTs
@@ -138,11 +138,33 @@ describe('getPaygoAddressProofIndex', () => {
 // Small test to verify, leave in this test file
 describe('trimMessagePrefix', function () {
   it('should be the same proof constructed consistently', function () {
-    const reconstructedProof = Buffer.concat([
+    const psbt = getTestPsbt();
+    psbt.addOutput({ script: utxolib.address.toOutputScript(addressToVerify, network), value: BigInt(10000) });
+    const outputIndex = psbt.data.outputs.length - 1;
+    addPayGoAddressProof(psbt, outputIndex, sig, addressProofEntropy);
+    // manually check without the verify function to see if the entropy being stored
+    // in the psbt is the same as the entropy being extracted and trimmed.
+    const psbtOutputs = checkForOutput(psbt.data.outputs, outputIndex);
+    const stored = utxolib.bitgo.getProprietaryKeyValuesFromUnknownKeyValues(psbtOutputs, {
+      identifier: utxolib.bitgo.PSBT_PROPRIETARY_IDENTIFIER,
+      subtype: utxolib.bitgo.ProprietaryKeySubtype.PAYGO_ADDRESS_ATTESTATION_PROOF,
+    });
+
+    assert(stored[0].key.keydata.equals(payGoAttestationProofComponents.entropy));
+    assert(stored[0].value.equals(sig));
+
+    const reconstructedProofFromComponents = Buffer.concat([
       payGoAttestationProofComponents.entropy,
       payGoAttestationProofComponents.address,
       payGoAttestationProofComponents.uuid,
     ]);
-    assert(addressProofMsgBuffer.equals(reconstructedProof));
+    const verifyConstructedProof = createPayGoAttestationBuffer(
+      addressToVerify,
+      stored[0].key.keydata,
+      utxolib.networks.bitcoin
+    );
+
+    assert(addressProofMsgBuffer.equals(reconstructedProofFromComponents));
+    assert(verifyConstructedProof.equals(reconstructedProofFromComponents));
   });
 });