Add v2/teth tests in bitgoExpressEth

Summary:
This file contains test for the teth-subset of bitgo-express

Squashed commits

* fix testutil eslint complaints: otherwise arc diff complains
* fix testutil assertion: prevent terminal garbage

Reviewers: barath

Reviewed By: barath

Subscribers: ben

Differential Revision: https://phabricator.bitgo.com/D6179

Author: OttoAllmendinger

test/bitgoExpressEth.js

@@ -0,0 +1,131 @@
+if (process.browser) {
+  throw new Error('bitgo express tests not supported in browser');
+}
+
+const request = require('supertest-as-promised');
+const Promise = require('bluebird');
+const co = Promise.coroutine;
+const BN = require('ethereumjs-util').BN;
+
+const expressApp = require('../src/expressApp');
+const TestBitGo = require('./lib/test_bitgo');
+const testUtil = require('./testutil');
+
+
+// this should exist on the test env hand have some eth funding
+const testWalletId = '598f606cd8fc24710d2ebadb1d9459bb';
+const testWalletPassphrase = 'moon';
+
+// this address belongs to the test wallet
+const testWalletFirstAddress = '0xdf07117705a9f8dc4c2a78de66b7f1797dba9d4e';
+
+describe('Bitgo Express TETH v2', function () {
+  let agent;
+
+  const authHeader = {
+    Authorization: 'Bearer ' + TestBitGo.TEST_ACCESSTOKEN
+  };
+
+  before(co(function *() {
+    let args = {
+      debug: false,
+      env: 'test',
+      logfile: '/dev/null',
+    };
+    let bitgo = new TestBitGo();
+    bitgo.initializeTestVars();
+    let app = expressApp(args);
+    agent = request.agent(app);
+    yield testUtil.unlockToken(agent, TestBitGo.TEST_ACCESSTOKEN, 15);
+  }));
+
+  it('can create new wallet and delete it', co(function *() {
+    const label = 'bitgoExpressEth.js temporary test wallet';
+    let res = yield agent
+      .post('/api/v2/teth/wallet/generate')
+      .set(authHeader)
+      .send({ passphrase: testWalletPassphrase, label });
+    res.statusCode.should.equal(200);
+
+    res = yield agent
+      .delete(`/api/v2/teth/wallet/${res.body.id}`)
+      .set(authHeader)
+      .send({ passphrase: testWalletPassphrase });
+    res.statusCode.should.equal(200);
+  }));
+
+  it('can list wallets', co(function *() {
+    let res = yield agent
+      .get('/api/v2/teth/wallet')
+      .set(authHeader);
+    res.statusCode.should.equal(200);
+    res.body.wallets.length.should.not.equal(0);
+  }));
+
+  it('can fetch testWallet', co(function *() {
+    let res = yield agent
+      .get(`/api/v2/teth/wallet/${testWalletId}`)
+      .set(authHeader);
+    res.statusCode.should.equal(200);
+    res.body.id.should.equal(testWalletId);
+
+    ((new BN(res.body.spendableBalanceString)).gt(0)).should.equal(true);
+  }));
+
+  it('can list deposit addresses', co(function *() {
+    let res = yield agent
+      .get(`/api/v2/teth/wallet/${testWalletId}/addresses`)
+      .set(authHeader);
+    res.statusCode.should.equal(200);
+    res.body.addresses
+      .filter(({ address }) => address === testWalletFirstAddress).length
+      .should.equal(1);
+  }));
+
+  it('can create new address', co(function *() {
+    let res = yield agent
+      .post(`/api/v2/teth/wallet/${testWalletId}/address`)
+      .set(authHeader);
+    res.statusCode.should.equal(200);
+  }));
+
+  it('can do sendcoins', co(function *() {
+    // fetch one new address
+    let res = yield agent
+      .post(`/api/v2/teth/wallet/${testWalletId}/address`)
+      .set(authHeader);
+    res.statusCode.should.equal(200);
+    let { address } = res.body;
+
+    res = yield agent
+      .post(`/api/v2/teth/wallet/${testWalletId}/sendcoins`)
+      .set(authHeader)
+      .send({
+        walletPassphrase: testWalletPassphrase,
+        address: address,
+        amount: '10000'
+      });
+    res.statusCode.should.equal(200);
+  }));
+
+  // Disabled, see JIRA BG-994
+  xit('can do sendmany', co(function *() {
+    // fetch two new address
+    let res, address1, address2;
+    res = yield agent.post(`/api/v2/teth/wallet/${testWalletId}/address`).set(authHeader);
+    address1 = res.body.address;
+    res = yield agent.post(`/api/v2/teth/wallet/${testWalletId}/address`).set(authHeader);
+    address2 = res.body.address;
+
+    res = yield agent
+      .post(`/api/v2/teth/wallet/${testWalletId}/sendmany`)
+      .set(authHeader)
+      .send({
+        recipients: [
+          { address: address1, amount: '10000' },
+          { address: address2, amount: '20000' },
+        ]
+      });
+    res.statusCode.should.equal(200);
+  }));
+});

test/testutil.js

@@ -37,7 +37,7 @@ TestUtil.promiseWhile = function(condition, body) {
   function loop() {
     // When the result of calling `condition` is no longer true, we are
     // done.
-    if (!condition()) return done.resolve();
+    if (!condition()) {return done.resolve();}
     // Use `when`, in case `body` does not return a promise.
     // When it completes loop again otherwise, if it fails, reject the
     // done promise
@@ -60,7 +60,7 @@ TestUtil.deleteTestTokens = function(bitgoObj, filterFunc) {
   var tokenList;
   var index = 0;
 
-  var condition = function() { return index < tokenList.length }; // don't delete last token, which is the login token for this test
+  var condition = function() { return index < tokenList.length; }; // don't delete last token, which is the login token for this test
   var body = function() {
     var token = tokenList[index];
 
@@ -93,6 +93,6 @@ TestUtil.unlockToken = function(agent, accessToken, seconds) {
   .set('Authorization', 'Bearer ' + accessToken)
   .send({ otp: '0000000', duration: seconds })
   .then(function(res) {
-    res.should.have.status(200);
-  })
+    res.statusCode.should.equal(200);
+  });
 };