refactor: move IcpAgent stubs to beforeEach for better test isolation

TICKET: WIN-5302

Author: mohd-kashif

modules/sdk-coin-icp/test/unit/transactionBuilder/transactionRecover.ts

@@ -40,6 +40,12 @@ describe('ICP transaction recovery', async () => {
     broadcastResponse = Buffer.from(testData.PublicNodeApiBroadcastResponse, 'hex');
   });
 
+  beforeEach(function () {
+    // Common stubs for IcpAgent
+    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
+    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
+  });
+
   afterEach(function () {
     recoveryParams = {
       userKey: testData.WRWRecovery.userKey,
@@ -66,8 +72,6 @@ describe('ICP transaction recovery', async () => {
     });
 
     const body = testData.RecoverySignedTransactionWithDefaultMemo;
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     nock(nodeUrl).post(broadcastEndpoint, body).reply(200, broadcastResponse);
     const recoverTxn = await icp.recover(recoveryParams);
     recoverTxn.id.should.be.a.String();
@@ -88,8 +92,6 @@ describe('ICP transaction recovery', async () => {
     });
 
     const body = testData.RecoverySignedTransactionWithMemo;
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     nock(nodeUrl).post(broadcastEndpoint, body).reply(200, broadcastResponse);
     recoveryParams.memo = testData.MetaDataWithMemo.memo;
     const recoverTxn = await icp.recover(recoveryParams);
@@ -109,8 +111,6 @@ describe('ICP transaction recovery', async () => {
       ingressEndTime: testData.MetaDataWithMemo.ingress_end,
     });
 
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     const unsignedSweepRecoveryParams = {
       bitgoKey:
         '0310768736a005ea5364e1b5b5288cf553224dd28b2df8ced63b72a8020478967f05ec5bce1f26cd7eb009a4bea445bb55c2f54a30f2706c1a3747e8df2d288829',
@@ -133,8 +133,6 @@ describe('ICP transaction recovery', async () => {
       ingressEndTime: testData.MetaDataWithMemo.ingress_end,
     });
 
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     const unsignedSweepRecoveryParams = {
       bitgoKey: 'testKey',
       recoveryDestination: testData.Accounts.account2.address,
@@ -156,17 +154,13 @@ describe('ICP transaction recovery', async () => {
       ingressEndTime: testData.MetaDataWithMemo.ingress_end,
     });
 
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     const unsignedSweepRecoveryParams = {
       recoveryDestination: testData.Accounts.account2.address,
     };
     await icp.recover(unsignedSweepRecoveryParams).should.rejectedWith('Error during ICP recovery: missing bitgoKey');
   });
 
   it('should fail to recover if broadcast API fails', async () => {
-    sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(1000000000));
-    sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     nock(nodeUrl).post(broadcastEndpoint).reply(500, 'Internal Server Error');
     recoveryParams.memo = 0;
     await icp
@@ -177,6 +171,8 @@ describe('ICP transaction recovery', async () => {
   });
 
   it('should fail to recover txn if balance is low', async () => {
+    // Override the default balance stub for this specific test
+    sinon.restore();
     sinon.stub(IcpAgent.prototype, 'getBalance').resolves(BigNumber(10));
     sinon.stub(IcpAgent.prototype, 'getFee').resolves(BigNumber(10000));
     nock(nodeUrl).post(broadcastEndpoint).reply(200, broadcastResponse);