feat(sdk-coin-icp): fix memo id validation

Ticket: WIN-5495

Author: DinshawKothari

modules/sdk-coin-icp/src/lib/transactionBuilder.ts

@@ -1,10 +1,10 @@
+import { BaseAddress, BaseKey, BaseTransactionBuilder, BuildTransactionError, SigningError } from '@bitgo/sdk-core';
 import { BaseCoin as CoinConfig } from '@bitgo/statics';
 import BigNumber from 'bignumber.js';
-import { BaseTransactionBuilder, BuildTransactionError, BaseAddress, SigningError, BaseKey } from '@bitgo/sdk-core';
-import { Transaction } from './transaction';
-import utils from './utils';
 import { DEFAULT_MEMO, IcpTransaction, IcpTransactionData, PayloadsData, Signatures } from './iface';
 import { SignedTransactionBuilder } from './signedTransactionBuilder';
+import { Transaction } from './transaction';
+import utils from './utils';
 
 export abstract class TransactionBuilder extends BaseTransactionBuilder {
   protected _transaction: Transaction;
@@ -58,7 +58,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
    * @returns {TransactionBuilder} This transaction builder
    */
   public memo(memo: number): this {
-    if (memo < 0) {
+    if (typeof memo !== 'number' || Number.isNaN(memo) || memo < 0) {
       throw new BuildTransactionError(`Invalid memo: ${memo}`);
     }
     this._memo = memo;

modules/sdk-coin-icp/test/unit/transactionBuilder/transactionBuilder.ts

@@ -1,9 +1,10 @@
+import { BaseKey, BuildTransactionError } from '@bitgo/sdk-core';
+import assert from 'assert';
 import should from 'should';
-import { getBuilderFactory } from '../getBuilderFactory';
-import { BaseKey } from '@bitgo/sdk-core';
-import * as testData from '../../resources/icp';
 import sinon from 'sinon';
 import { DEFAULT_MEMO, MAX_INGRESS_TTL } from '../../../src/lib/iface';
+import * as testData from '../../resources/icp';
+import { getBuilderFactory } from '../getBuilderFactory';
 
 describe('ICP Transaction Builder', async () => {
   const factory = getBuilderFactory('ticp');
@@ -66,6 +67,17 @@ describe('ICP Transaction Builder', async () => {
     await txBuilder.build().should.rejectedWith('sender is required before building');
   });
 
+  it('should fail to build a txn with incorrect memo', async () => {
+    const txBuilder = factory.getTransferBuilder();
+    txBuilder.sender(testData.Accounts.account1.address, testData.Accounts.account1.publicKey);
+    txBuilder.receiverId(testData.Accounts.account2.address);
+    txBuilder.amount('10');
+    const incorrectMemos = ['abcd', undefined];
+    for (const memo of incorrectMemos) {
+      assert.throws(() => txBuilder.memo(Number(memo)), BuildTransactionError, `Invalid memo: ${Number(memo)}`);
+    }
+  });
+
   it('should fail to build a txn without amount', async () => {
     const txBuilder = factory.getTransferBuilder();
     txBuilder.sender(testData.Accounts.account1.address, testData.Accounts.account1.publicKey);