use instanceof in Parser constructor

Thomas Kerin · Thomas Kerin · commit a7577ecff092 · 2017-12-30T00:23:53.000Z
diff --git a/src/Buffertools/Parser.php b/src/Buffertools/Parser.php
@@ -30,14 +30,12 @@ class Parser
      */
     public function __construct(BufferInterface $input = null)
     {
-        $this->position = 0;
-
-        if (null === $input) {
-            $this->string = '';
-            $this->size = 0;
-        } else {
+        if ($input instanceof BufferInterface) {
             $this->string = $input->getBinary();
             $this->size = $input->getSize();
+        } else {
+            $this->string = '';
+            $this->size = 0;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,12 @@ class Parser`
`30`	`30`	`*/`
`31`	`31`	`public function __construct(BufferInterface $input = null)`
`32`	`32`	`{`
`33`		`- $this->position = 0;`
`34`		`-`
`35`		`- if (null === $input) {`
`36`		`- $this->string = '';`
`37`		`- $this->size = 0;`
`38`		`- } else {`
	`33`	`+ if ($input instanceof BufferInterface) {`
`39`	`34`	`$this->string = $input->getBinary();`
`40`	`35`	`$this->size = $input->getSize();`
	`36`	`+ } else {`
	`37`	`+ $this->string = '';`
	`38`	`+ $this->size = 0;`
`41`	`39`	`}`
`42`	`40`	`}`
`43`	`41`