Add support for altcoins and file mode fix #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Convert the public key to the address. | ||
| return BitcoinLib::public_key_to_address($public, $import['version']); | ||
| return BitcoinLib::public_key_to_address($public, $address_version!==null?$address_version:$import['version']); |
Member
There was a problem hiding this comment.
please add spaces $address_version !== null ? $address_version : $import['version']
Member
|
Phpcbf would fix these nits: Regarding the BIP32 bytes, since this library is maintenance only, completeness is more vital. Have you seen the other lib? github.com/bit-wasp/bitcoin-php. You can implement a NetworkInterface easily enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some fix for altcoin support and added constants for Monacoin support.
Also, I removed execution-rights for some PHP files (which seems to be unintentionally granted).
This change is originally written for building the EC-service CoinGift.