Skip to content

Commit aa91c26

Browse files
authored
adds the observation printer to all core systems (#1078)
This is an essential component that enables observation printing, so we should probably have it in all our systems. Also tweaked a bit the description of the component, the old one was quite vague.
1 parent 0d978b7 commit aa91c26

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

plugins/primus_print/primus_print_main.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,9 @@ let start_monitoring {Config.get=(!)} =
185185
Machine.return ()
186186
end in
187187
Primus.Machine.add_component (module Monitor) [@warning "-D"];
188-
Primus.Components.register_generic "monitor" (module Monitor)
188+
Primus.Components.register_generic "observation-printer" (module Monitor)
189189
~package:"bap"
190-
~desc:"Monitors the specified set of observations and prints \
191-
a trace of recorded observations when a machine finishes."
190+
~desc:"Prints the specified set of observations. Controlled via \
191+
the primus-print plugin."
192192

193193
let () = Config.when_ready start_monitoring

plugins/primus_systems/systems/core.asd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
:components (bap:load-binary
44
bap:program-loader
55
bap:x86-flag-initializer
6-
bap:powerpc-init))
6+
bap:powerpc-init
7+
bap:observation-printer))
78

89
(defsystem bap:base-lisp-machine
910
:description "Executes Primus Lisp program."

plugins/primus_test/lisp/memcheck-malloc.lisp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
(when (is-in name 'memchr 'memrchr)
3535
(memcheck-bounds 'malloc ptr len)))
3636

37-
38-
39-
4037
(defun check/both (dst src len)
4138
(memcheck-bounds 'malloc src len)
4239
(memcheck-bounds 'malloc dst len))

0 commit comments

Comments
 (0)