Skip to content

Commit 693449c

Browse files
universalmind303universalmind303
authored
drop support for i686 windows target (pola-rs#152)
* drop support for i686 windows target * upgrade biome
1 parent 032e867 commit 693449c

File tree

11 files changed

+70
-96
lines changed

11 files changed

+70
-96
lines changed

‎.github/workflows/create-js-release.yaml

-18
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,6 @@ jobs:
2424
architecture: x64
2525
build: yarn build
2626
target: x86_64-pc-windows-msvc
27-
- host: windows-latest
28-
build: |
29-
export CARGO_PROFILE_RELEASE_CODEGEN_UNITS=128;
30-
export CARGO_PROFILE_RELEASE_LTO=false
31-
npm run build -- --target i686-pc-windows-msvc
32-
target: i686-pc-windows-msvc
33-
architecture: x86
3427
- host: ubuntu-latest
3528
architecture: x64
3629
target: x86_64-unknown-linux-gnu
@@ -140,19 +133,8 @@ jobs:
140133
run: ${{ matrix.settings.setup }}
141134
if: ${{ matrix.settings.setup }}
142135
shell: bash
143-
- name: Setup node x86
144-
if: matrix.settings.target == 'i686-pc-windows-msvc'
145-
run: yarn config set supportedArchitectures.cpu "ia32"
146136
- name: Install dependencies
147137
run: yarn install
148-
- name: Setup node x86
149-
uses: actions/setup-node@v4
150-
if: matrix.settings.target == 'i686-pc-windows-msvc'
151-
with:
152-
node-version: 20
153-
check-latest: true
154-
cache: yarn
155-
architecture: x86
156138
- name: Build in docker
157139
uses: addnab/docker-run-action@v3
158140
if: ${{ matrix.settings.docker }}

‎.yarn/install-state.gz

-6.22 KB
Binary file not shown.

‎__tests__/expr.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -956,7 +956,7 @@ describe("expr.str", () => {
956956
a: ["Foo", "foo", "FoO"],
957957
});
958958

959-
const re = new RegExp("foo", "i");
959+
const re = /foo/i;
960960
const expected = pl.DataFrame({
961961
a: ["Foo", "foo", "FoO"],
962962
contains: [true, true, true],

‎biome.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
},
1313
"suspicious": {
1414
"noExplicitAny": "off",
15-
"noUnsafeDeclarationMerging": "off"
15+
"noUnsafeDeclarationMerging": "off",
16+
"noImplicitAnyLet": "off"
1617

1718
},
1819
"complexity": {

‎npm/win32-ia32-msvc/README.md

-3
This file was deleted.

‎npm/win32-ia32-msvc/package.json

-33
This file was deleted.

‎package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
"aarch64-unknown-linux-gnu",
2727
"aarch64-unknown-linux-musl",
2828
"aarch64-linux-android",
29-
"i686-pc-windows-msvc",
3029
"x86_64-unknown-linux-musl"
3130
]
3231
}
@@ -55,7 +54,7 @@
5554
"precommit": "yarn lint && yarn test"
5655
},
5756
"devDependencies": {
58-
"@biomejs/biome": "^1.4.1",
57+
"@biomejs/biome": "^1.5.0",
5958
"@napi-rs/cli": "^2.17.0",
6059
"@types/chance": "^1.1.6",
6160
"@types/jest": "^29.5.11",

‎polars/datatypes/datatype.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,10 @@ class _Categorical extends DataType {}
171171
* Datetime type
172172
*/
173173
class _Datetime extends DataType {
174-
constructor(private timeUnit: TimeUnit, private timeZone?: string) {
174+
constructor(
175+
private timeUnit: TimeUnit,
176+
private timeZone?: string,
177+
) {
175178
super();
176179
}
177180
override get inner() {

‎polars/datatypes/field.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ export interface Field {
99
}
1010

1111
export class Field implements Field {
12-
constructor(public name: string, public dtype: DataType) {}
12+
constructor(
13+
public name: string,
14+
public dtype: DataType,
15+
) {}
1316
toString() {
1417
return `Field("${this.name}", ${this.dtype})`;
1518
}

‎polars/lazy/expr/index.ts

+6-4
Original file line numberDiff line numberDiff line change
@@ -585,10 +585,12 @@ export const _Expr = (_expr: any): Expr => {
585585
return _Expr(unwrap(method, ...args));
586586
};
587587

588-
const wrapExprArg = (method: string, lit = false) => (other: any) => {
589-
const expr = exprToLitOrExpr(other, lit).inner();
590-
return wrap(method, expr);
591-
};
588+
const wrapExprArg =
589+
(method: string, lit = false) =>
590+
(other: any) => {
591+
const expr = exprToLitOrExpr(other, lit).inner();
592+
return wrap(method, expr);
593+
};
592594

593595
const rolling =
594596
(method: string) =>

‎yarn.lock

+52-32
Original file line numberDiff line numberDiff line change
@@ -408,73 +408,93 @@ __metadata:
408408
languageName: node
409409
linkType: hard
410410

411-
"@biomejs/biome@npm:^1.4.1":
412-
version: 1.4.1
413-
resolution: "@biomejs/biome@npm:1.4.1"
414-
dependencies:
415-
"@biomejs/cli-darwin-arm64": 1.4.1
416-
"@biomejs/cli-darwin-x64": 1.4.1
417-
"@biomejs/cli-linux-arm64": 1.4.1
418-
"@biomejs/cli-linux-x64": 1.4.1
419-
"@biomejs/cli-win32-arm64": 1.4.1
420-
"@biomejs/cli-win32-x64": 1.4.1
411+
"@biomejs/biome@npm:^1.5.0":
412+
version: 1.5.0
413+
resolution: "@biomejs/biome@npm:1.5.0"
414+
dependencies:
415+
"@biomejs/cli-darwin-arm64": 1.5.0
416+
"@biomejs/cli-darwin-x64": 1.5.0
417+
"@biomejs/cli-linux-arm64": 1.5.0
418+
"@biomejs/cli-linux-arm64-musl": 1.5.0
419+
"@biomejs/cli-linux-x64": 1.5.0
420+
"@biomejs/cli-linux-x64-musl": 1.5.0
421+
"@biomejs/cli-win32-arm64": 1.5.0
422+
"@biomejs/cli-win32-x64": 1.5.0
421423
dependenciesMeta:
422424
"@biomejs/cli-darwin-arm64":
423425
optional: true
424426
"@biomejs/cli-darwin-x64":
425427
optional: true
426428
"@biomejs/cli-linux-arm64":
427429
optional: true
430+
"@biomejs/cli-linux-arm64-musl":
431+
optional: true
428432
"@biomejs/cli-linux-x64":
429433
optional: true
434+
"@biomejs/cli-linux-x64-musl":
435+
optional: true
430436
"@biomejs/cli-win32-arm64":
431437
optional: true
432438
"@biomejs/cli-win32-x64":
433439
optional: true
434440
bin:
435441
biome: bin/biome
436-
checksum: 6b016b2b5c48df6af6b74eda75dc9e36a9d2c88911d6a0f1e11dbf25906645ae61bc6366e299aa97c931a96fea9284bdab5e843950110083dc2ce597f70f14b8
442+
checksum: 86f3a59fb1614a552a6fe47722140c06472a5e0f8d17e03d72991e69b8f1d565250b386aca695d920d7c7a8b5b3f3fff263171674892e0415698b64b319ec628
437443
languageName: node
438444
linkType: hard
439445

440-
"@biomejs/cli-darwin-arm64@npm:1.4.1":
441-
version: 1.4.1
442-
resolution: "@biomejs/cli-darwin-arm64@npm:1.4.1"
446+
"@biomejs/cli-darwin-arm64@npm:1.5.0":
447+
version: 1.5.0
448+
resolution: "@biomejs/cli-darwin-arm64@npm:1.5.0"
443449
conditions: os=darwin & cpu=arm64
444450
languageName: node
445451
linkType: hard
446452

447-
"@biomejs/cli-darwin-x64@npm:1.4.1":
448-
version: 1.4.1
449-
resolution: "@biomejs/cli-darwin-x64@npm:1.4.1"
453+
"@biomejs/cli-darwin-x64@npm:1.5.0":
454+
version: 1.5.0
455+
resolution: "@biomejs/cli-darwin-x64@npm:1.5.0"
450456
conditions: os=darwin & cpu=x64
451457
languageName: node
452458
linkType: hard
453459

454-
"@biomejs/cli-linux-arm64@npm:1.4.1":
455-
version: 1.4.1
456-
resolution: "@biomejs/cli-linux-arm64@npm:1.4.1"
457-
conditions: os=linux & cpu=arm64
460+
"@biomejs/cli-linux-arm64-musl@npm:1.5.0":
461+
version: 1.5.0
462+
resolution: "@biomejs/cli-linux-arm64-musl@npm:1.5.0"
463+
conditions: os=linux & cpu=arm64 & libc=musl
464+
languageName: node
465+
linkType: hard
466+
467+
"@biomejs/cli-linux-arm64@npm:1.5.0":
468+
version: 1.5.0
469+
resolution: "@biomejs/cli-linux-arm64@npm:1.5.0"
470+
conditions: os=linux & cpu=arm64 & libc=glibc
471+
languageName: node
472+
linkType: hard
473+
474+
"@biomejs/cli-linux-x64-musl@npm:1.5.0":
475+
version: 1.5.0
476+
resolution: "@biomejs/cli-linux-x64-musl@npm:1.5.0"
477+
conditions: os=linux & cpu=x64 & libc=musl
458478
languageName: node
459479
linkType: hard
460480

461-
"@biomejs/cli-linux-x64@npm:1.4.1":
462-
version: 1.4.1
463-
resolution: "@biomejs/cli-linux-x64@npm:1.4.1"
464-
conditions: os=linux & cpu=x64
481+
"@biomejs/cli-linux-x64@npm:1.5.0":
482+
version: 1.5.0
483+
resolution: "@biomejs/cli-linux-x64@npm:1.5.0"
484+
conditions: os=linux & cpu=x64 & libc=glibc
465485
languageName: node
466486
linkType: hard
467487

468-
"@biomejs/cli-win32-arm64@npm:1.4.1":
469-
version: 1.4.1
470-
resolution: "@biomejs/cli-win32-arm64@npm:1.4.1"
488+
"@biomejs/cli-win32-arm64@npm:1.5.0":
489+
version: 1.5.0
490+
resolution: "@biomejs/cli-win32-arm64@npm:1.5.0"
471491
conditions: os=win32 & cpu=arm64
472492
languageName: node
473493
linkType: hard
474494

475-
"@biomejs/cli-win32-x64@npm:1.4.1":
476-
version: 1.4.1
477-
resolution: "@biomejs/cli-win32-x64@npm:1.4.1"
495+
"@biomejs/cli-win32-x64@npm:1.5.0":
496+
version: 1.5.0
497+
resolution: "@biomejs/cli-win32-x64@npm:1.5.0"
478498
conditions: os=win32 & cpu=x64
479499
languageName: node
480500
linkType: hard
@@ -3067,7 +3087,7 @@ __metadata:
30673087
version: 0.0.0-use.local
30683088
resolution: "nodejs-polars@workspace:."
30693089
dependencies:
3070-
"@biomejs/biome": ^1.4.1
3090+
"@biomejs/biome": ^1.5.0
30713091
"@napi-rs/cli": ^2.17.0
30723092
"@types/chance": ^1.1.6
30733093
"@types/jest": ^29.5.11

0 commit comments

Comments
 (0)