Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can the plugin work with superagent-jsonp #24

Open
jieyou opened this issue Feb 23, 2016 · 2 comments
Open

can the plugin work with superagent-jsonp #24

jieyou opened this issue Feb 23, 2016 · 2 comments

Comments

@jieyou
Copy link

jieyou commented Feb 23, 2016

Thank you for build such a useful plugin.
Now I've got a problem , I use superagent-jsonp in dev environment. But it seems to can't work with your superagent-mock plugin.
Is there any way to solve the problem?

@fdubost
Copy link
Member

fdubost commented Feb 23, 2016

I don't use superagent-jsonp but it seems that this library use the same way to override superagent methods, so I'm not surprised that these plugins can't work both 😞

@oziks
Copy link
Contributor

oziks commented Mar 11, 2016

I think we need to remove the jsonp call when superagent-mock is used. jsonp is useless if superagent is mocked.
This could be done easily by overriding the use method on superagent-mock.

What do you think about this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants