Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a library with the same name. #52

Open
wlxo0401 opened this issue Jan 10, 2024 · 3 comments
Open

There is a library with the same name. #52

wlxo0401 opened this issue Jan 10, 2024 · 3 comments

Comments

@wlxo0401
Copy link

https://github.com/scalessec/Toast-Swift

There is a library with the same name, so wouldn't this be a problem??

I think there can be confusion for people.

https://github.com/danielgindi/Charts

In the case of the existing Charts library, there is a case where the name was changed to DGCharts because the name overlapped with the SwiftUI library.

@Nikoloutsos
Copy link
Contributor

Hello @wlxo0401 thank you for sharing your concern,
Indeed when you depend on both you get the following error:
CleanShot 2024-01-10 at 12 19 18

OOC did you came up to this issue because your project uses both libraries? I am not sure how easy it is to change the name since I think it will introduce breaking changes to developers.

What do you think?

@wlxo0401
Copy link
Author

Hello @wlxo0401 thank you for sharing your concern, Indeed when you depend on both you get the following error: CleanShot 2024-01-10 at 12 19 18

OOC did you came up to this issue because your project uses both libraries? I am not sure how easy it is to change the name since I think it will introduce breaking changes to developers.

What do you think?

I'm not currently experiencing any issues. However, considering that this library is actively being developed, I'm concerned that as the user base grows, there might be potential issues arising in the future due to the overlapping names of the libraries.

While it's unlikely that many people are using both libraries with the same name, I was concerned about the confusion it could cause in situations like Stackoverflow searches and other similar �situation.

@Zandor300
Copy link
Contributor

The Cocoapods name of this library is ToastViewSwift. Just wanted to mention that for this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants