Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests #30

Open
Nikoloutsos opened this issue Jan 26, 2023 · 2 comments
Open

Add snapshot tests #30

Nikoloutsos opened this issue Jan 26, 2023 · 2 comments

Comments

@Nikoloutsos
Copy link
Contributor

I think it is worth adding some snapshot tests on the views.
That way we can be more confident merging PRs.
Also, we can add a Github action workflow for running the snapshot tests in every pull request.
IIRC github actions are free for open source project ❤️

What do you think? @BastiaanJansen

@BastiaanJansen
Copy link
Owner

Great idea. I hadn't heard about Snapshot testing. Though I did play around with E2E tests for Swift, but I think Snapshot tests are a better fit!
I am familiar with GitHub Actions and use it in my other OS projects as well.

Would you mind looking into it if you have time?

@Nikoloutsos
Copy link
Contributor Author

Sure, we can do this 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants